Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2906943002: [Fuchsia] Calculate RSS using new task stat fields (Closed)

Created:
3 years, 7 months ago by dbort
Modified:
3 years, 6 months ago
Reviewers:
zra, zanderso
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Fuchsia] Calculate RSS using new task stat fields mem_committed_bytes is deprecated and will go away. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/9779e2db96de20e7e9eb4b1290632cfdc8fc4449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/bin/process_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dbort
This will need to go in: after https://fuchsia-review.googlesource.com/c/31942/ before https://fuchsia-review.googlesource.com/c/31944/ The new RSS value is ...
3 years, 7 months ago (2017-05-26 19:31:56 UTC) #2
zra
lgtm If you ping this issue after the first change lands, I'll roll Dart forward ...
3 years, 7 months ago (2017-05-26 19:49:36 UTC) #3
dbort
Ok, the required parent commit is in magenta/master as https://fuchsia.googlesource.com/magenta/+/2fc52476d524765eadd7198ba736ea9696313c7b
3 years, 7 months ago (2017-05-26 22:14:02 UTC) #4
zra
Committed patchset #1 (id:1) manually as 9779e2db96de20e7e9eb4b1290632cfdc8fc4449 (presubmit successful).
3 years, 7 months ago (2017-05-26 22:15:55 UTC) #6
zra
On 2017/05/26 22:15:55, zra wrote: > Committed patchset #1 (id:1) manually as > 9779e2db96de20e7e9eb4b1290632cfdc8fc4449 (presubmit ...
3 years, 7 months ago (2017-05-26 22:18:32 UTC) #7
zra
3 years, 6 months ago (2017-05-30 16:55:31 UTC) #8
Message was sent while issue was closed.
On 2017/05/26 22:18:32, zra wrote:
> On 2017/05/26 22:15:55, zra wrote:
> > Committed patchset #1 (id:1) manually as
> > 9779e2db96de20e7e9eb4b1290632cfdc8fc4449 (presubmit successful).
> 
> Landed in Dart. I'll do the roll into Fuchsia after the bots cycle green.

This change is now rolled into Fuchsia.

Powered by Google App Engine
This is Rietveld 408576698