Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 290693004: [AiS] Fix assignment and copy ctor. (Closed)

Created:
6 years, 7 months ago by groby-ooo-7-16
Modified:
6 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

[AiS] Fix assignment and copy ctor. These were missing from http://crrev.com/285343004, which added two new fields to AutocompleteMatch. BUG=370192 R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/autocomplete/autocomplete_match.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
6 years, 7 months ago (2014-05-17 00:15:00 UTC) #1
Peter Kasting
Blargh LGTM
6 years, 7 months ago (2014-05-17 00:16:24 UTC) #2
groby-ooo-7-16
If you think these small changes are mostly annoying, happy to just TBR :)
6 years, 7 months ago (2014-05-17 00:46:37 UTC) #3
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 7 months ago (2014-05-17 00:46:39 UTC) #4
Peter Kasting
On 2014/05/17 00:46:37, groby wrote: > If you think these small changes are mostly annoying, ...
6 years, 7 months ago (2014-05-17 00:47:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/290693004/1
6 years, 7 months ago (2014-05-17 00:48:36 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 17:41:33 UTC) #7
Message was sent while issue was closed.
Change committed as 271248

Powered by Google App Engine
This is Rietveld 408576698