Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 290693002: Remove the unused close_on_interstitial_webui setting. (Closed)

Created:
6 years, 7 months ago by msw
Modified:
6 years, 7 months ago
Reviewers:
Mike Wittman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove the unused close_on_interstitial_webui setting. BUG=374011, 374011 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271250

Patch Set 1 : Remove the unused close_on_interstitial_webui setting. #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -50 lines) Patch
M components/web_modal/web_contents_modal_dialog_manager.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager.cc View 3 chunks +5 lines, -25 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager_unittest.cc View 1 1 chunk +12 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Hey Mike, please take a look; thanks!
6 years, 7 months ago (2014-05-16 21:27:35 UTC) #1
Mike Wittman
lgtm with a comment https://codereview.chromium.org/290693002/diff/20001/components/web_modal/web_contents_modal_dialog_manager_unittest.cc File components/web_modal/web_contents_modal_dialog_manager_unittest.cc (right): https://codereview.chromium.org/290693002/diff/20001/components/web_modal/web_contents_modal_dialog_manager_unittest.cc#newcode273 components/web_modal/web_contents_modal_dialog_manager_unittest.cc:273: native_manager2->StopTracking(); This should be something ...
6 years, 7 months ago (2014-05-16 21:37:32 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 7 months ago (2014-05-16 22:38:09 UTC) #3
msw
https://codereview.chromium.org/290693002/diff/20001/components/web_modal/web_contents_modal_dialog_manager_unittest.cc File components/web_modal/web_contents_modal_dialog_manager_unittest.cc (right): https://codereview.chromium.org/290693002/diff/20001/components/web_modal/web_contents_modal_dialog_manager_unittest.cc#newcode273 components/web_modal/web_contents_modal_dialog_manager_unittest.cc:273: native_manager2->StopTracking(); On 2014/05/16 21:37:32, Mike Wittman wrote: > This ...
6 years, 7 months ago (2014-05-16 22:38:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/290693002/40001
6 years, 7 months ago (2014-05-16 23:33:56 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 14:42:33 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 17:58:01 UTC) #7
Message was sent while issue was closed.
Change committed as 271250

Powered by Google App Engine
This is Rietveld 408576698