chrome/browser/notifications/notification_platform_bridge_android.cc - Issue 2906913002: Move handler processing to NotificationDisplayService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_platform_bridge_android.cc

Issue 2906913002: Move handler processing to NotificationDisplayService. (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_handler.h ('k') | chrome/browser/notifications/notification_platform_bridge_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_platform_bridge_android.cc

diff --git a/chrome/browser/notifications/notification_platform_bridge_android.cc b/chrome/browser/notifications/notification_platform_bridge_android.cc

index 716f1f01657331a64845d20bbf54419b76e72280..7ed7fcfd9d575f045c844b8c4fe3d62ee72ab142 100644

--- a/chrome/browser/notifications/notification_platform_bridge_android.cc

+++ b/chrome/browser/notifications/notification_platform_bridge_android.cc

@@ -15,9 +15,9 @@

#include "base/strings/nullable_string16.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/browser_process.h"

-#include "chrome/browser/notifications/native_notification_display_service.h"

#include "chrome/browser/notifications/notification.h"

#include "chrome/browser/notifications/notification_common.h"

+#include "chrome/browser/notifications/notification_display_service.h"

#include "chrome/browser/notifications/notification_display_service_factory.h"

#include "chrome/browser/notifications/persistent_notification_delegate.h"

#include "chrome/browser/notifications/platform_notification_service_impl.h"

@@ -116,12 +116,12 @@ void ProfileLoadedCallback(NotificationCommon::Operation operation,

return;

}

- NotificationDisplayService* display_service =

+ auto* display_service =

NotificationDisplayServiceFactory::GetForProfile(profile);

- static_cast<NativeNotificationDisplayService*>(display_service)

- ->ProcessNotificationOperation(operation, notification_type, origin,

- notification_id, action_index, reply);

+ display_service->ProcessNotificationOperation(operation, notification_type,

+ origin, notification_id,

+ action_index, reply);

}

} // namespace