Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2083)

Unified Diff: chrome/browser/notifications/notification_object_proxy.cc

Issue 2906883003: Deprecate per notification type delegates. (Closed)
Patch Set: review Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_object_proxy.cc
diff --git a/chrome/browser/notifications/notification_object_proxy.cc b/chrome/browser/notifications/notification_object_proxy.cc
deleted file mode 100644
index 55a8b848f18719f5fa3a7f0d70c6c649f8b21662..0000000000000000000000000000000000000000
--- a/chrome/browser/notifications/notification_object_proxy.cc
+++ /dev/null
@@ -1,49 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/notifications/notification_object_proxy.h"
-
-#include <utility>
-
-#include "base/logging.h"
-#include "chrome/browser/notifications/platform_notification_service_impl.h"
-#include "content/public/browser/desktop_notification_delegate.h"
-#include "url/gurl.h"
-
-NotificationObjectProxy::NotificationObjectProxy(
- content::BrowserContext* browser_context,
- const std::string& notification_id,
- const GURL& origin,
- std::unique_ptr<content::DesktopNotificationDelegate> delegate)
- : WebNotificationDelegate(browser_context, notification_id, origin),
- delegate_(std::move(delegate)),
- displayed_(false) {}
-
-NotificationObjectProxy::~NotificationObjectProxy() {}
-
-void NotificationObjectProxy::Display() {
- // This method is called each time the notification is shown to the user
- // but we only want to fire the event the first time.
- if (displayed_)
- return;
-
- displayed_ = true;
-
- delegate_->NotificationDisplayed();
-}
-
-void NotificationObjectProxy::Close(bool by_user) {
- delegate_->NotificationClosed();
-}
-
-void NotificationObjectProxy::Click() {
- delegate_->NotificationClick();
-}
-
-void NotificationObjectProxy::ButtonClick(int button_index) {
- // Notification buttons not are supported for non persistent notifications.
- DCHECK_EQ(button_index, 0);
-
- NotificationCommon::OpenNotificationSettings(browser_context());
-}

Powered by Google App Engine
This is Rietveld 408576698