Deprecate per notification type delegates.

chrome/browser/notifications/web_notification_delegate.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/web_notification_delegate.h"
 
 #include "base/feature_list.h"
 #include "base/metrics/histogram_macros.h"
-#include "chrome/browser/notifications/notification_common.h"
+#include "base/strings/nullable_string16.h"
+#include "chrome/browser/notifications/notification_display_service.h"
+#include "chrome/browser/notifications/notification_display_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
 #include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/message_center/notifier_settings.h"
 
 using message_center::NotifierId;
 
 namespace features {
 
 const base::Feature kAllowFullscreenWebNotificationsFeature{
   "FSNotificationsWeb", base::FEATURE_ENABLED_BY_DEFAULT
 };
 
 } // namespace features
 
-
 WebNotificationDelegate::WebNotificationDelegate(
-    content::BrowserContext* browser_context,
+    NotificationCommon::Type notification_type,
+    Profile* profile,
     const std::string& notification_id,
     const GURL& origin)
-    : browser_context_(browser_context),
+    : notification_type_(notification_type),
+      profile_(profile),
       notification_id_(notification_id),
       origin_(origin) {}
 
 WebNotificationDelegate::~WebNotificationDelegate() {}
 
 std::string WebNotificationDelegate::id() const {
   return notification_id_;
 }
 
 bool WebNotificationDelegate::SettingsClick() {
 #if !defined(OS_CHROMEOS)
-  NotificationCommon::OpenNotificationSettings(browser_context_);
+  NotificationCommon::OpenNotificationSettings(profile_);
   return true;
 #else
   return false;
 #endif
 }
 
 bool WebNotificationDelegate::ShouldDisplaySettingsButton() {
   return true;
 }
 
 bool WebNotificationDelegate::ShouldDisplayOverFullscreen() const {

[Peter Beverloo, 2017/06/08 06:48:11]

I guess these buttons should also migrate to the NotificationHandler eventually?

[Miguel Garcia, 2017/06/09 12:24:51]

Yes! in progress CL for that
https://codereview.chromium.org/2921263002/patch/160001/170033

 #if !defined(OS_ANDROID)
-  Profile* profile = Profile::FromBrowserContext(browser_context_);
-  DCHECK(profile);
   // Check to see if this notification comes from a webpage that is displaying
   // fullscreen content.
   for (auto* browser : *BrowserList::GetInstance()) {
     // Only consider the browsers for the profile that created the notification
-    if (browser->profile() != profile)
+    if (browser->profile() != profile_)
       continue;
 
     const content::WebContents* active_contents =
         browser->tab_strip_model()->GetActiveWebContents();
     if (!active_contents)
       continue;
 
     // Check to see if
     //  (a) the active tab in the browser shares its origin with the
     //      notification.
@@ skipping 14 matching lines @@
             NotifierId::WEB_PAGE,
             NotifierId::SIZE);
       }
       return enabled;
     }
   }
 #endif
 
   return false;
 }
+
+void WebNotificationDelegate::Display() {}
+
+void WebNotificationDelegate::Close(bool by_user) {
+  auto* display_service =
+      NotificationDisplayServiceFactory::GetForProfile(profile_);
+  display_service->ProcessNotificationOperation(
+      NotificationCommon::CLOSE, notification_type_, origin().spec(),
+      notification_id_, -1, base::NullableString16());
+}
+
+void WebNotificationDelegate::Click() {
+  auto* display_service =
+      NotificationDisplayServiceFactory::GetForProfile(profile_);
+  display_service->ProcessNotificationOperation(
+      NotificationCommon::CLICK, notification_type_, origin().spec(),
+      notification_id_, -1, base::NullableString16());
+}
+
+void WebNotificationDelegate::ButtonClick(int button_index) {
+  DCHECK(button_index >= 0);
+  auto* display_service =
+      NotificationDisplayServiceFactory::GetForProfile(profile_);
+  display_service->ProcessNotificationOperation(
+      NotificationCommon::CLICK, notification_type_, origin().spec(),
+      notification_id_, button_index, base::NullableString16());
+}
+
+void WebNotificationDelegate::ButtonClickWithReply(
+    int button_index,
+    const base::string16& reply) {
+  auto* display_service =
+      NotificationDisplayServiceFactory::GetForProfile(profile_);
+  display_service->ProcessNotificationOperation(
+      NotificationCommon::CLICK, notification_type_, origin().spec(),
+      notification_id_, button_index,
+      base::NullableString16(reply, false /* is_null */));
+}