third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js - Issue 2906843002: [Devtools] Move to canReplayRequest in NetworkRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2906843002: [Devtools] Move to canReplayRequest in NetworkRequest (Closed)

Patch Set: [Devtools] Move to canReplayRequest in NetworkRequest Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

index cc55d6f20c8e07f9b8e0290af3b478deab959c1e..613d959dd878c674ca62f7370579ec775ce2b8a8 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

@@ -567,9 +567,9 @@ Console.ConsoleView = class extends UI.VBox {

contextMenu.appendItem(Common.UIString('Save as...'), this._saveConsole.bind(this));

var request = consoleMessage ? consoleMessage.request : null;

- if (request && request.resourceType() === Common.resourceTypes.XHR) {

+ if (request && request.canReplayRequest()) {

contextMenu.appendSeparator();

- contextMenu.appendItem(Common.UIString('Replay XHR'), request.replayXHR.bind(request));

+ contextMenu.appendItem(Common.UIString('Replay XHR'), request.replayRequest.bind(request));

}

contextMenu.show();