Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 2906843002: [Devtools] Move to canReplayRequest in NetworkRequest (Closed)
Patch Set: [Devtools] Move to canReplayRequest in NetworkRequest Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1090 matching lines...) Expand 10 before | Expand all | Expand 10 after
1101 * @param {string} eventName 1101 * @param {string} eventName
1102 * @param {string} eventId 1102 * @param {string} eventId
1103 * @param {string} data 1103 * @param {string} data
1104 */ 1104 */
1105 addEventSourceMessage(time, eventName, eventId, data) { 1105 addEventSourceMessage(time, eventName, eventId, data) {
1106 var message = {time: this.pseudoWallTime(time), eventName: eventName, eventI d: eventId, data: data}; 1106 var message = {time: this.pseudoWallTime(time), eventName: eventName, eventI d: eventId, data: data};
1107 this._eventSourceMessages.push(message); 1107 this._eventSourceMessages.push(message);
1108 this.dispatchEventToListeners(SDK.NetworkRequest.Events.EventSourceMessageAd ded, message); 1108 this.dispatchEventToListeners(SDK.NetworkRequest.Events.EventSourceMessageAd ded, message);
1109 } 1109 }
1110 1110
1111 replayXHR() { 1111 /**
1112 * @return {boolean}
1113 */
1114 canReplayRequest() {
pfeldman 2017/05/30 17:39:45 I thought that it would move to the network manage
allada 2017/05/31 23:30:13 I was going to move this after I remove the refere
1115 return this._resourceType === Common.resourceTypes.XHR;
1116 }
1117
1118 replayRequest() {
1112 this._networkManager.target().networkAgent().replayXHR(this._requestId); 1119 this._networkManager.target().networkAgent().replayXHR(this._requestId);
1113 } 1120 }
1114 1121
1115 /** 1122 /**
1116 * @return {!SDK.NetworkManager} 1123 * @return {!SDK.NetworkManager}
1117 */ 1124 */
1118 networkManager() { 1125 networkManager() {
1119 return this._networkManager; 1126 return this._networkManager;
1120 } 1127 }
1121 }; 1128 };
(...skipping 26 matching lines...) Expand all
1148 Send: 'send', 1155 Send: 'send',
1149 Receive: 'receive', 1156 Receive: 'receive',
1150 Error: 'error' 1157 Error: 'error'
1151 }; 1158 };
1152 1159
1153 /** @typedef {!{type: SDK.NetworkRequest.WebSocketFrameType, time: number, text: string, opCode: number, mask: boolean}} */ 1160 /** @typedef {!{type: SDK.NetworkRequest.WebSocketFrameType, time: number, text: string, opCode: number, mask: boolean}} */
1154 SDK.NetworkRequest.WebSocketFrame; 1161 SDK.NetworkRequest.WebSocketFrame;
1155 1162
1156 /** @typedef {!{time: number, eventName: string, eventId: string, data: string}} */ 1163 /** @typedef {!{time: number, eventName: string, eventId: string, data: string}} */
1157 SDK.NetworkRequest.EventSourceMessage; 1164 SDK.NetworkRequest.EventSourceMessage;
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698