Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2168)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 2906763002: [TTS] Add some initial signals for Tap in content. (Closed)
Patch Set: Just fix an off-by-one bug on an index bounds found by a failing test. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
index 3f43032a04195889d686a236ac5143c9455ec21b..7075f12ab148f573becf4c53c5f2fa3d348e2c90 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
@@ -1475,13 +1475,14 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega
@Override
public void decideSuppression() {
mInternalStateController.notifyStartingWorkOn(InternalState.DECIDING_SUPPRESSION);
+
// Ranker will handle the suppression, but our legacy implementation uses
// TapSuppressionHeuristics (run from the ContextualSearchSelectionConroller).
// Usage includes tap-far-from-previous suppression.
mTapSuppressionRankerLogger.setupLoggingForPage(getBasePageUrl());
// TODO(donnd): Move handleShouldSuppressTap out of the Selection Controller.
- mSelectionController.handleShouldSuppressTap(mTapSuppressionRankerLogger);
+ mSelectionController.handleShouldSuppressTap(mContext, mTapSuppressionRankerLogger);
}
/** Starts showing the Tap UI by selecting a word around the current caret. */

Powered by Google App Engine
This is Rietveld 408576698