chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java - Issue 2906763002: [TTS] Add some initial signals for Tap in content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 2906763002: [TTS] Add some initial signals for Tap in content. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

index fc22a8e0145a99d572dbba9323e996e8bc7d9554..382c962157bd6b2446ab45d551180999786dac59 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

@@ -1442,7 +1442,7 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega

@Override

public void decideSuppression() {

mInternalStateController.notifyStartingWorkOn(InternalState.DECIDING_SUPPRESSION);

- mSelectionController.handleShouldSuppressTap();

+ mSelectionController.handleShouldSuppressTap(mContext);

}

/** Starts showing the Tap UI by selecting a word around the current caret. */