[Extenisons UI] Remove extension_action_redesign logic from the toolbar

chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

Index: chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
diff --git a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
index 99d3ae16d5e4461cb8a854375eea27c0f8da0351..0a902a3050a524e6fa04c1672a658e49062de90e 100644
--- a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
+++ b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
@@ -124,6 +124,8 @@ void ExtensionMessageBubbleBrowserTest::TestBubbleAnchoredToAppMenu() {
           extensions::extension_action_test_util::NO_ACTION,
           extensions::Manifest::UNPACKED);
   extension_service()->AddExtension(no_action_extension.get());
+  extension_service()->DisableExtension(
+      no_action_extension->id(), extensions::Extension::DISABLE_NOT_VERIFIED);

[Finnur, 2017/05/30 13:26:15]

It is not immediately obvious why this (and below) is related to removing the
last remnants of this toolbar-redesign-flag....

[Devlin, 2017/05/30 22:33:31]

Good point!  The reason is that, now that all extensions have actions, very few
bubbles still anchor to the app menu.  The suspicious extension bubble (warning
users about extensions that were disabled for not being from the webstore) is
one of the ones that does, so we trigger that one instead of the dev mode
bubble.

I've added comments to document this.

   Browser* second_browser = new Browser(Browser::CreateParams(profile(), true));
   ASSERT_TRUE(second_browser);
   second_browser->window()->Show();
@@ -148,6 +150,9 @@ void ExtensionMessageBubbleBrowserTest::
           extensions::Manifest::INTERNAL);
   extension_service()->AddExtension(action_extension.get());
 
+  extension_service()->DisableExtension(
+      no_action_extension->id(), extensions::Extension::DISABLE_NOT_VERIFIED);
+
   Browser* second_browser = new Browser(Browser::CreateParams(profile(), true));
   ASSERT_TRUE(second_browser);
   second_browser->window()->Show();