tools/metrics/histograms/histograms.xml - Issue 2906723002: Track how often we would attempt to resolve non-'compliant' domain names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2906723002: Track how often we would attempt to resolve non-'compliant' domain names. (Closed)

Patch Set: Respond to comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index fde40f26e83c1fb6e0e6d8f46a4ca389d4d8b413..b735976b74977a86c9ad40f5a8bdda12829964e8 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -35388,6 +35388,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>Please list the metric's owners. Add more owner tags as needed.</owner>

</histogram>

+<histogram name="Net.DNSNameCompliantIfValid" enum="Boolean">

+ <owner>palmer@chromium.org</owner>

+ <summary>

+ True if Net.ValidDNSName is true and if |net::IsCanonicalizedHostCompliant|

Mark P 2017/05/31 23:08:12 nit: I think this makes more sense if you omit "if

palmer 2017/05/31 23:36:15 Done.

+ returns true. Used to see if IsCanonicalizedHostCompliant() runs afoul of

+ real websites. This histogram is recorded when converting dotted DNS names

+ into DNS query form, in preparation for issuing a DNS request. This

+ histogram is only recorded if Net.ValidDNSName is true.

+ </summary>

+</histogram>

<histogram name="Net.DoubleGetExperiment_InitialResponseMethod"

enum="DoubleGetExperimentMethods">

« no previous file with comments | « net/dns/dns_util.cc ('k') | no next file » | no next file with comments »