Modify PrinterSetupResult enum to constant style.

chrome/browser/chromeos/printing/printer_configurer.h

Index: chrome/browser/chromeos/printing/printer_configurer.h
diff --git a/chrome/browser/chromeos/printing/printer_configurer.h b/chrome/browser/chromeos/printing/printer_configurer.h
index 5aab7a34369378432f9c9ff980173e4ffe30eb5c..0d540c07a1861d4365be997b1d0dda542ff5b45b 100644
--- a/chrome/browser/chromeos/printing/printer_configurer.h
+++ b/chrome/browser/chromeos/printing/printer_configurer.h
@@ -15,16 +15,18 @@ class Profile;
 namespace chromeos {
 
 enum PrinterSetupResult {
-  FATAL_ERROR,
-  SUCCESS,              // Printer set up successfully
-  PRINTER_UNREACHABLE,  // Could not reach printer
-  DBUS_ERROR,           // Could not contact debugd
+  kFatalError = 0,          // Setup failed in an unrecognized way
+  kSuccess = 1,             // Printer set up successfully
+  kPrinterUnreachable = 2,  // Could not reach printer
+  kDbusError = 3,           // Could not contact debugd
+  // Space left for additional errors

[Lei Zhang, 2017/05/25 22:53:03]

Can you explain why this is needed?

[skau, 2017/05/25 23:11:07]

I'm leaving space for non-PPD errors and thought it might be nice.  There's no
logic that depends on this right now.  Is there a significant downside?

[Lei Zhang, 2017/05/25 23:24:06]

OK, the CL description hinted that you are going to use these for something. I
noticed https://codereview.chromium.org/2911523002 now. I didn't see it before
so I wasn't sure where you were going with this.

 
   // PPD errors
-  PPD_TOO_LARGE,     // PPD exceeds size limit
-  INVALID_PPD,       // PPD rejected by cupstestppd
-  PPD_NOT_FOUND,     // Could not find PPD
-  PPD_UNRETRIEVABLE  // Could not download PPD
+  kPpdTooLarge = 10,       // PPD exceeds size limit
+  kInvalidPpd = 11,        // PPD rejected by cupstestppd
+  kPpdNotFound = 12,       // Could not find PPD
+  kPpdUnretrievable = 13,  // Could not download PPD
+  kMaxValue = kPpdUnretrievable
 };
 
 using PrinterSetupCallback = base::Callback<void(PrinterSetupResult)>;