Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: net/http/transport_security_state.cc

Issue 2906633003: Add a build flag to configure bundling of HSTS preload list (Closed)
Patch Set: address sleevi comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_security_headers_unittest.cc ('k') | net/http/transport_security_state_static.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/transport_security_state.cc
diff --git a/net/http/transport_security_state.cc b/net/http/transport_security_state.cc
index d4d6f495199460c4af336f05ba4f5c5b3649a278..5d03bb54f7e1b04368ab24ea71ce938f03975d9e 100644
--- a/net/http/transport_security_state.cc
+++ b/net/http/transport_security_state.cc
@@ -639,8 +639,8 @@ bool DecodeHSTSPreloadRaw(const std::string& search_hostname,
bool DecodeHSTSPreload(const std::string& hostname, PreloadResult* out) {
bool found;
if (!DecodeHSTSPreloadRaw(hostname, &found, out)) {
- DCHECK(false) << "Internal error in DecodeHSTSPreloadRaw for hostname "
- << hostname;
+ // This can happen when INCLUDE_TRANSPORT_SECURITY_STATE_PRELOAD_LIST is
+ // false, in which can BitReader.seek(0) will return false.
xunjieli 2017/06/30 19:12:18 Ryan, I had to update the code to not DCHECK(false
return false;
}
« no previous file with comments | « net/http/http_security_headers_unittest.cc ('k') | net/http/transport_security_state_static.template » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698