Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2906603003: - Process the Dart_kCanonicalizeUrl tag in both VMparser and Kernel modes. (Closed)

Created:
3 years, 7 months ago by siva
Modified:
3 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Process the Dart_kCanonicalizeUrl tag in both VMparser and Kernel modes. - Add assertion for tag to be Dart_kScriptTag in Kernel mode. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4de9d7162939405457592474ccd7214d39323f93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M runtime/bin/loader.cc View 2 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
3 years, 7 months ago (2017-05-26 00:03:13 UTC) #2
rmacnak
lgtm
3 years, 7 months ago (2017-05-26 00:09:23 UTC) #3
siva
3 years, 7 months ago (2017-05-26 00:30:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4de9d7162939405457592474ccd7214d39323f93 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698