Files.app: Add 'link' to the allowed effects in dataTransfer objects.

ui/file_manager/file_manager/foreground/js/file_transfer_controller.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Global (placed in the window object) variable name to hold internal
  * file dragging information. Needed to show visual feedback while dragging
  * since DataTransfer object is in protected state. Reachable from other
@@ skipping 147 matching lines @@
                                     this.onPaste_.bind(this));
     this.copyCommand_ = this.document_.querySelector('command#copy');
   },
 
   /**
    * Write the current selection to system clipboard.
    *
    * @this {FileTransferController}
    * @param {DataTransfer} dataTransfer DataTransfer from the event.
    * @param {string} effectAllowed Value must be valid for the
-   *     |dataTransfer.effectAllowed| property ('move', 'copy', 'copyMove').
+   *     |dataTransfer.effectAllowed| property.
    */
   cutOrCopy_: function(dataTransfer, effectAllowed) {
     // Existence of the volumeInfo is checked in canXXX methods.
     var volumeInfo = this.volumeManager_.getVolumeInfo(
         this.currentDirectoryContentEntry);
     // Tag to check it's filemanager data.
     dataTransfer.setData('fs/tag', 'filemanager-data');
     dataTransfer.setData('fs/sourceRootURL',
                          volumeInfo.fileSystem.root.toURL());
     var sourceURLs = util.entriesToURLs(this.selectedEntries_);
@@ skipping 143 matching lines @@
    *     |dataTransfer.effectAllowed|.
    * @return {string} Either "copy" or "move".
    */
   paste: function(dataTransfer, opt_destinationEntry, opt_effect) {
     var sourceURLs = dataTransfer.getData('fs/sources') ?
         dataTransfer.getData('fs/sources').split('\n') : [];
     // effectAllowed set in copy/paste handlers stay uninitialized. DnD handlers
     // work fine.
     var effectAllowed = dataTransfer.effectAllowed !== 'uninitialized' ?
         dataTransfer.effectAllowed : dataTransfer.getData('fs/effectallowed');
-    var toMove = effectAllowed === 'move' ||
-        (effectAllowed === 'copyMove' && opt_effect === 'move');
+    var toMove = util.isDropEffectAllowed(effectAllowed, 'move') &&
+        (!util.isDropEffectAllowed(effectAllowed, 'copy') ||
+         opt_effect === 'move');
     var destinationEntry =
         opt_destinationEntry || this.currentDirectoryContentEntry;
     var entries;
     var failureUrls;
 
     util.URLsToEntries(sourceURLs).
     then(function(result) {
       entries = result.entries;
       failureUrls = result.failureUrls;
       // Check if cross share is needed or not.
@@ skipping 138 matching lines @@
     if (!this.selectedEntries_.length) {
       event.preventDefault();
       return;
     }
 
     var dt = event.dataTransfer;
     var canCopy = this.canCopyOrDrag_(dt);
     var canCut = this.canCutOrDrag_(dt);
     if (canCopy || canCut) {
       if (canCopy && canCut) {
-        this.cutOrCopy_(dt, 'copyMove');
+        this.cutOrCopy_(dt, 'all');
       } else if (canCopy) {
-        this.cutOrCopy_(dt, 'copy');
+        this.cutOrCopy_(dt, 'copyLink');
       } else {
         this.cutOrCopy_(dt, 'move');
       }
     } else {
       event.preventDefault();
       return;
     }
 
     var dragThumbnail = this.renderThumbnail_();
     dt.setDragImage(dragThumbnail, 1000, 1000);
@@ skipping 535 matching lines @@
    */
   selectDropEffect_: function(event, destinationEntry) {
     if (!destinationEntry)
       return 'none';
     var destinationLocationInfo =
         this.volumeManager_.getLocationInfo(destinationEntry);
     if (!destinationLocationInfo)
       return 'none';
     if (destinationLocationInfo.isReadOnly)
       return 'none';
-    if (event.dataTransfer.effectAllowed === 'move')
-      return 'move';
-    // TODO(mtomasz): Use volumeId instead of comparing roots, as soon as
-    // volumeId gets unique.
-    if (event.dataTransfer.effectAllowed === 'copyMove' &&
-        this.getSourceRootURL_(event.dataTransfer) ===
-            destinationLocationInfo.volumeInfo.fileSystem.root.toURL() &&
-        !event.ctrlKey) {
-      return 'move';
-    }
-    if (event.dataTransfer.effectAllowed === 'copyMove' &&
-        event.shiftKey) {
-      return 'move';
+    if (util.isDropEffectAllowed(event.dataTransfer.effectAllowed, 'move')) {
+      if (!util.isDropEffectAllowed(event.dataTransfer.effectAllowed, 'copy'))
+        return 'move';
+      // TODO(mtomasz): Use volumeId instead of comparing roots, as soon as
+      // volumeId gets unique.
+      if (this.getSourceRootURL_(event.dataTransfer) ===
+              destinationLocationInfo.volumeInfo.fileSystem.root.toURL() &&
+          !event.ctrlKey) {
+        return 'move';
+      }
+      if (event.shiftKey) {
+        return 'move';
+      }
     }
     return 'copy';
   },
 };