Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 290653002: Files.app: Add 'link' to the allowed effects in dataTransfer objects. (Closed)

Created:
6 years, 7 months ago by kinaba
Modified:
6 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Files.app: Add 'link' effect to the allowed list in drag-and-drop dataTransfer objects. BUG=373537 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271035

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -18 lines) Patch
M ui/file_manager/file_manager/common/js/util.js View 1 chunk +13 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 4 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kinaba
6 years, 7 months ago (2014-05-16 06:23:29 UTC) #1
hirono
https://codereview.chromium.org/290653002/diff/1/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js (right): https://codereview.chromium.org/290653002/diff/1/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js#newcode332 ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:332: var toMove = !util.isDropEffectAllowed(effectAllowed, 'copy') || How about the ...
6 years, 7 months ago (2014-05-16 07:00:39 UTC) #2
kinaba
https://codereview.chromium.org/290653002/diff/1/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js (right): https://codereview.chromium.org/290653002/diff/1/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js#newcode332 ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:332: var toMove = !util.isDropEffectAllowed(effectAllowed, 'copy') || On 2014/05/16 07:00:39, ...
6 years, 7 months ago (2014-05-16 07:09:13 UTC) #3
hirono
lgtm! Thank you!
6 years, 7 months ago (2014-05-16 07:16:16 UTC) #4
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-16 07:17:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/290653002/20001
6 years, 7 months ago (2014-05-16 07:17:24 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 08:58:39 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 10:02:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/27754)
6 years, 7 months ago (2014-05-16 10:02:58 UTC) #9
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-16 15:48:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/290653002/20001
6 years, 7 months ago (2014-05-16 15:48:21 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 16:56:05 UTC) #12
Message was sent while issue was closed. 
Change committed as 271035

Powered by Google App Engine
This is Rietveld 408576698