ARC: Add BootType parameter to ReportBootProgress() in metrics.mojom

components/arc/common/metrics.mojom

Index: components/arc/common/metrics.mojom
diff --git a/components/arc/common/metrics.mojom b/components/arc/common/metrics.mojom
index cb2e93650e6069327e610729674f4906ad46f373..42c8461f9e4d2488328e1fce32c6bf78726b8b9a 100644
--- a/components/arc/common/metrics.mojom
+++ b/components/arc/common/metrics.mojom
@@ -1,9 +1,22 @@
 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
+// Next MinVersion: 2
 
 module arc.mojom;
 
+[Extensible]
+enum BootType {
+  UNKNOWN = 0,
+  // This is for the very first (opt-in) boot.
+  FIRST_BOOT = 1,
+  // This is for the first boot after Chrome OS update which also updates the
+  // ARC++ image.

[Luis Héctor Chávez, 2017/05/25 16:00:35]

nit: s/ARC++/ARC/

[Yusuke Sato, 2017/05/25 18:21:13]

Done.

+  FIRST_BOOT_AFTER_UPDATE = 2,
+  // This is for regular boot.
+  REGULAR_BOOT = 3,
+};
+
 // Describes a boot progress event.
 struct BootProgressEvent {
   // Name of the boot progress event in Android. Currently there are
@@ -23,11 +36,18 @@ struct BootProgressEvent {
   int64 uptimeMillis;
 };
 
+// Next method ID: 2
+// Deprecated method ID: 0
 interface MetricsHost {
-  // Report boot progress events from ARC instance.
+  // DEPRECATED. Use ReportBootProgressWithType instead.
   ReportBootProgress@0(array<BootProgressEvent> events);

[Luis Héctor Chávez, 2017/05/25 16:00:35]

You don't need to deprecate this :)

ReportBootProgress@0(array<BootProgressEvent> events,
                     [MinVersion=1] BootType boot_type);

Don't know if BootType should be optional (marked with a ?) or not, though.

[Yusuke Sato, 2017/05/25 18:21:13]

Done.

Used BootType without '?' because '?' is not allowed for enums. Tested with new
Chrome + new Android, old Chrome + new Android, and new Chrome + old Android.
For the third one, confirmed that UNKNOWN (0) is passed to Chrome.

+
+  // Report boot progress events from ARC instance.
+  [MinVersion=1] ReportBootProgressWithType@1(array<BootProgressEvent> events,
+                                              BootType boot_type);
 };
 
+// Next method ID: 1
 interface MetricsInstance {
   Init@0(MetricsHost host_ptr);
 };