tools/metrics/histograms/histograms.xml - Issue 2906503003: ARC: Add BootType parameter to ReportBootProgress() in metrics.mojom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2906503003: ARC: Add BootType parameter to ReportBootProgress() in metrics.mojom (Closed)

Patch Set: Address comment Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index d76c6f8ffa5d9a8ceeccc93c9f82f20bb210a9e1..dc68f9e26befd011ffd8b0ef760a7252199aba12 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -84494,6 +84494,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<affected-histogram name="Arc.boot_progress"/>

</histogram_suffixes>

+<histogram_suffixes name="AndroidBootTypes" separator=".">

+ <suffix name="FIRST_BOOT" label="For the very first boot aka opt-in."/>

Ilya Sherman 2017/05/25 22:32:08 nit: Please add a comma between "boot" and "aka"

Yusuke Sato 2017/05/25 23:18:42 Done.

+ <suffix name="FIRST_BOOT_AFTER_UPDATE"

+ label="For the first boot after Chrome OS update."/>

+ <suffix name="REGULAR_BOOT" label="For regular boot."/>

Ilya Sherman 2017/05/25 22:32:08 nit: s/For/For a

Yusuke Sato 2017/05/25 23:18:42 Done.

+ <affected-histogram name="Arc.AndroidBootTime"/>

+ <affected-histogram name="Arc.boot_progress_ams_ready"/>

+ <affected-histogram name="Arc.boot_progress_enable_screen"/>

+ <affected-histogram name="Arc.boot_progress_pms_data_scan_start"/>

+ <affected-histogram name="Arc.boot_progress_pms_ready"/>

+ <affected-histogram name="Arc.boot_progress_pms_scan_end"/>

+ <affected-histogram name="Arc.boot_progress_pms_start"/>

+ <affected-histogram name="Arc.boot_progress_pms_system_scan_start"/>

+ <affected-histogram name="Arc.boot_progress_preload_end"/>

+ <affected-histogram name="Arc.boot_progress_preload_start"/>

+ <affected-histogram name="Arc.boot_progress_start"/>

+ <affected-histogram name="Arc.boot_progress_system_run"/>

+</histogram_suffixes>

<histogram_suffixes name="AndroidCrashUploadTypes" separator="_">