Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Side by Side Diff: components/arc/common/metrics.mojom

Issue 2906503003: ARC: Add BootType parameter to ReportBootProgress() in metrics.mojom (Closed)
Patch Set: Address comments from Luis Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/arc/metrics/arc_metrics_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // Next MinVersion: 2
4 5
5 module arc.mojom; 6 module arc.mojom;
6 7
8 [Extensible]
9 enum BootType {
10 UNKNOWN = 0,
Luis Héctor Chávez 2017/05/25 18:24:30 nit: Add a comment that this is only used for comp
Yusuke Sato 2017/05/25 19:50:50 Done.
11 // This is for the very first (opt-in) boot.
12 FIRST_BOOT = 1,
13 // This is for the first boot after Chrome OS update which also updates the
14 // ARC image.
15 FIRST_BOOT_AFTER_UPDATE = 2,
16 // This is for regular boot.
17 REGULAR_BOOT = 3,
18 };
19
7 // Describes a boot progress event. 20 // Describes a boot progress event.
8 struct BootProgressEvent { 21 struct BootProgressEvent {
9 // Name of the boot progress event in Android. Currently there are 22 // Name of the boot progress event in Android. Currently there are
10 // 11 boot progress events found in Android source repository: 23 // 11 boot progress events found in Android source repository:
11 // system/core/logcat/event.logtags 24 // system/core/logcat/event.logtags
12 // frameworks/base/services/core/java/com/android/server/am/ 25 // frameworks/base/services/core/java/com/android/server/am/
13 // EventLogTags.logtags 26 // EventLogTags.logtags
14 // frameworks/base/services/core/java/com/android/server/ 27 // frameworks/base/services/core/java/com/android/server/
15 // EventLogTags.logtags 28 // EventLogTags.logtags
16 string event; 29 string event;
17 30
18 // Timestamp of the event in uptime obtained in ARC. The uptime 31 // Timestamp of the event in uptime obtained in ARC. The uptime
19 // is from clock source MONOTONIC_CLOCK since Chrome OS boots up. 32 // is from clock source MONOTONIC_CLOCK since Chrome OS boots up.
20 // Therefore, we need to calibrate the correct elapsed time of the 33 // Therefore, we need to calibrate the correct elapsed time of the
21 // event by comparing the uptime with the ARC start time from 34 // event by comparing the uptime with the ARC start time from
22 // the same clock source MONOTONIC_CLOCK in session manager. 35 // the same clock source MONOTONIC_CLOCK in session manager.
23 int64 uptimeMillis; 36 int64 uptimeMillis;
24 }; 37 };
25 38
39 // Next method ID: 1
26 interface MetricsHost { 40 interface MetricsHost {
27 // Report boot progress events from ARC instance. 41 // Report boot progress events from ARC instance.
28 ReportBootProgress@0(array<BootProgressEvent> events); 42 ReportBootProgress@0(array<BootProgressEvent> events,
43 [MinVersion=1] BootType boot_type);
29 }; 44 };
30 45
46 // Next method ID: 1
31 interface MetricsInstance { 47 interface MetricsInstance {
32 Init@0(MetricsHost host_ptr); 48 Init@0(MetricsHost host_ptr);
33 }; 49 };
OLDNEW
« no previous file with comments | « no previous file | components/arc/metrics/arc_metrics_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698