Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2906483003: Experiment with a compact mode for simple preloaded entries. (Closed)

Created:
3 years, 7 months ago by martijnc
Modified:
3 years, 3 months ago
Reviewers:
lgarron
CC:
cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Experiment with a compact mode for simple preloaded entries. BUG=603597

Patch Set 1 #

Patch Set 2 : Windows warning #

Patch Set 3 : Add a test. #

Patch Set 4 : Comments cbentzel. #

Patch Set 5 : Initialize all struct members. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -32 lines) Patch
M net/http/transport_security_state.cc View 1 2 3 4 2 chunks +46 lines, -32 lines 0 comments Download
M net/http/transport_security_state_static_unittest3.json View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M net/tools/transport_security_state_generator/trie/trie_writer.cc View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
martijnc
lgarron: I originally wrote this as an experiment but it might be worth landing. This ...
3 years, 5 months ago (2017-07-13 19:16:13 UTC) #4
lgarron
I'm sorry, this got filed away a long time back. :-( 5% is not much, ...
3 years, 3 months ago (2017-08-25 00:05:39 UTC) #5
martijnc
3 years, 3 months ago (2017-08-25 19:54:04 UTC) #7
On 2017/08/25 at 00:05:39, lgarron wrote:
> I'm sorry, this got filed away a long time back. :-(
> 
> 5% is not much, but then it's pretty significant compared to any pruning we
could do.
> Is this still usable/ready for review?

I've added a test and uploaded the patch to Gerrit for review.

https://chromium-review.googlesource.com/c/chromium/src/+/636423

Powered by Google App Engine
This is Rietveld 408576698