Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: net/http/http_stream_factory_impl_job_controller.cc

Issue 2906463002: Make HttpNetworkSession::host_mapping_rules no longer a pointer. (Closed)
Patch Set: Oops Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_job_controller.cc
diff --git a/net/http/http_stream_factory_impl_job_controller.cc b/net/http/http_stream_factory_impl_job_controller.cc
index 1e7ea76ade0fcbbf8bf9106caa33ab44ac0352c3..51004d0da349ff3cfdebc58c2fc8a92f6381770e 100644
--- a/net/http/http_stream_factory_impl_job_controller.cc
+++ b/net/http/http_stream_factory_impl_job_controller.cc
@@ -894,8 +894,9 @@ void HttpStreamFactoryImpl::JobController::MaybeNotifyFactoryOfCompletion() {
GURL HttpStreamFactoryImpl::JobController::ApplyHostMappingRules(
const GURL& url,
HostPortPair* endpoint) {
- const HostMappingRules* mapping_rules = session_->params().host_mapping_rules;
- if (mapping_rules && mapping_rules->RewriteHost(endpoint)) {
+ const HostMappingRules* mapping_rules =
+ &session_->params().host_mapping_rules;
+ if (mapping_rules->RewriteHost(endpoint)) {
Randy Smith (Not in Mondays) 2017/05/25 17:50:48 nit, suggestion: This might all fit on one line wi
mmenke 2017/05/25 18:07:10 Done.
url::Replacements<char> replacements;
const std::string port_str = base::UintToString(endpoint->port());
replacements.SetPort(port_str.c_str(), url::Component(0, port_str.size()));

Powered by Google App Engine
This is Rietveld 408576698