Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2906443002: Reapply convert fixes for dart2js (Closed)

Created:
3 years, 7 months ago by vsm
Modified:
3 years, 7 months ago
Reviewers:
floitsch
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M sdk/lib/_internal/js_runtime/lib/convert_patch.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 7 months ago (2017-05-24 14:35:41 UTC) #3
floitsch
LGTM.
3 years, 7 months ago (2017-05-24 14:36:30 UTC) #4
vsm
3 years, 7 months ago (2017-05-24 15:34:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
991315ae87baedeb3265970a0bc2111ff6fcd9ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698