veatest: Fixes for bitrate tests.

veatest: Fixes for bitrate tests.

- introduce a minimum number of frames for bitrate tests; if a stream is
  too short, loop it over as many times as needed to reach that minimum
- instead of using additional black frames to flush the encoder at the
  end of encode, just rewind and reuse frames from the beginning;
  this also eliminates the need for the CS_FINISHING state;
- switch to a more demanding/varied stream for bitrate tests (bear)

- also move the starting point of encoder FPS calculation from Initialize()
  to after setting up the buffers to slightly better estimate actual encoder
  performance
- minor additions to the documentation of and fixes for input buffer size
  calculation
- add ifdefs to only check alignment on ARM

BUG=366158
TEST=run test, ensure bitrates converge properly on relevant platforms

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272864

[Pawel Osciak, 2014-05-16 10:33:04]

ptal

[Pawel Osciak, 2014-05-16 10:33:05]

ptal

[Ami GONE FROM CHROMIUM, 2014-05-16 18:00:50]

LGTM

https://codereview.chromium.org/290643003/diff/1/content/common/gpu/media/vid...
File content/common/gpu/media/video_encode_accelerator_unittest.cc (right):

https://codereview.chromium.org/290643003/diff/1/content/common/gpu/media/vid...
content/common/gpu/media/video_encode_accelerator_unittest.cc:82: const char*
g_default_in_filename = "bear_192p40_frames.yuv";
why this change?

[Pawel Osciak, 2014-05-16 22:49:16]

https://codereview.chromium.org/290643003/diff/1/content/common/gpu/media/vid...
File content/common/gpu/media/video_encode_accelerator_unittest.cc (right):

https://codereview.chromium.org/290643003/diff/1/content/common/gpu/media/vid...
content/common/gpu/media/video_encode_accelerator_unittest.cc:82: const char*
g_default_in_filename = "bear_192p40_frames.yuv";
On 2014/05/16 18:00:50, Ami Fischman wrote:
> why this change?

Sync has a lot of black background and not as much going on. I was debating if I
should raise the low FPS case to something more than 3fps or give it a more
difficult stream. Decided this would be more interesting.

[Pawel Osciak, 2014-05-26 04:35:16]

The CQ bit was checked by posciak@chromium.org

[commit-bot: I haz the power, 2014-05-26 04:35:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/posciak@chromium.org/290643003/40001

[commit-bot: I haz the power, 2014-05-26 06:31:48]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-26 06:32:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-26 06:32:37]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Pawel Osciak, 2014-05-26 08:31:25]

The CQ bit was checked by posciak@chromium.org

[commit-bot: I haz the power, 2014-05-26 08:31:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/posciak@chromium.org/290643003/40001

[commit-bot: I haz the power, 2014-05-26 19:26:43]

Change committed as 272864