Teach PasswordAutofillAgent sometimes match prefixes of usernames

components/autofill/core/common/autofill_util.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/common/autofill_util.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
@@ skipping 97 matching lines @@
                             case_sensitive
                                 ? base::CompareCase::SENSITIVE
                                 : base::CompareCase::INSENSITIVE_ASCII);
   }
 
   return suggestion.length() >= field_contents.length() &&
          GetTextSelectionStart(suggestion, field_contents, case_sensitive) !=
              base::string16::npos;
 }
 
+bool IsPrefixOfEmailEndingAtSign(const base::string16& full_string,
+                                 const base::string16& prefix) {
+  auto at_sign = std::find(full_string.begin(), full_string.end(), '@');
+  auto e = full_string.end();
+  // weak check if |full_string| is a valid email address.

[vabr (Chromium), 2017/06/19 12:54:15]

nit: weak -> A weak
Or maybe better "An incomplete check".

[melandory, 2017/06/21 12:00:42]

Done.

+  bool is_email =

[vabr (Chromium), 2017/06/19 12:54:15]

Well, actually, hinting at e-mail, but only doing it just a little is confusing.
The original suggestion https://crbug.com/543435#c10 from the security team does
only request that instead of testing that the suggestion is a prefix of field
contents, we test that suggestion + "@" is a prefix of the field contents.

So I suggest replacing the whole function with just that:

base::StartsWith(full_string, prefix + "@", base::CompareCase::SENSITIVE));

with the following reasons:

* It is secure enough: this still respects origins and follows the security team
suggestion; also other incomplete e-mail address checks are not clearly better.
* Code will be significantly simpler.
* We might still tune this based on user feedback (I'm looking especially at the
CompareCase::SENSITIVE), so let's start simple.

[melandory, 2017/06/21 12:00:42]

In this case "ab@cd@g", "ab@cd" will result in match. Is it fine?

[vabr (Chromium), 2017/06/21 12:28:07]

I think it is fine. From usability perspective I don't see any issues, and for
security, this follows the guidance from security team given on the bug.

+      (at_sign != e                            // there is @
+       && std::find(at_sign, e, '.') != e      // there is . and it's after @
+       && std::find(++at_sign, e, '@') == e);  // there is at most 1 @
+  if (is_email &&
+      base::StartsWith(full_string, prefix, base::CompareCase::SENSITIVE)) {
+    return (full_string.size() > prefix.size() &&
+            full_string[prefix.size()] == '@');
+  }
+  return false;
+}
+
 size_t GetTextSelectionStart(const base::string16& suggestion,
                              const base::string16& field_contents,
                              bool case_sensitive) {
   const base::string16 kSplitChars = base::ASCIIToUTF16(kSplitCharacters);
 
   // Loop until we find either the |field_contents| is a prefix of |suggestion|
   // or character right before the match is one of the splitting characters.
   for (base::string16::const_iterator it = suggestion.begin();
        (it = std::search(
             it, suggestion.end(), field_contents.begin(), field_contents.end(),
@@ skipping 48 matching lines @@
 }
 
 std::vector<std::string> LowercaseAndTokenizeAttributeString(
     const std::string& attribute) {
   return base::SplitString(base::ToLowerASCII(attribute),
                            base::kWhitespaceASCII, base::TRIM_WHITESPACE,
                            base::SPLIT_WANT_NONEMPTY);
 }
 
 }  // namespace autofill