Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart

Issue 2906373002: Override ChangeBuilder methods in subclass to specify better type information (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
diff --git a/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart b/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
index 6ce511f8ff170230ee601b8cdabf224badcdec4c..c94b60ba28b6076486f2d4def024b813176ddd99 100644
--- a/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
+++ b/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
@@ -39,6 +39,11 @@ class DartChangeBuilderImpl extends ChangeBuilderImpl
DartChangeBuilderImpl(this.driver);
@override
+ Future<Null> addFileEdit(String path, int fileStamp,
+ void buildFileEdit(DartFileEditBuilder builder)) =>
+ super.addFileEdit(path, fileStamp, buildFileEdit);
+
+ @override
Future<DartFileEditBuilderImpl> createFileEditBuilder(
String path, int fileStamp) async {
AnalysisResult result = await driver.getResult(path);
@@ -62,6 +67,11 @@ class DartEditBuilderImpl extends EditBuilderImpl implements DartEditBuilder {
DartFileEditBuilderImpl get dartFileEditBuilder => fileEditBuilder;
@override
+ void addLinkedEdit(String groupName,
+ void buildLinkedEdit(DartLinkedEditBuilder builder)) =>
+ super.addLinkedEdit(groupName, buildLinkedEdit);
+
+ @override
LinkedEditBuilderImpl createLinkedEditBuilder() {
return new DartLinkedEditBuilderImpl(this);
}
@@ -971,6 +981,15 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
: super(changeBuilder, path, timeStamp);
@override
+ void addInsertion(int offset, void buildEdit(DartEditBuilder builder)) =>
+ super.addInsertion(offset, buildEdit);
+
+ @override
+ void addReplacement(
+ SourceRange range, void buildEdit(DartEditBuilder builder)) =>
+ super.addReplacement(range, buildEdit);
+
+ @override
void convertFunctionFromSyncToAsync(
FunctionBody body, TypeProvider typeProvider) {
if (body == null && body.keyword != null) {
« no previous file with comments | « no previous file | pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698