Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: Source/devtools/protocol.json

Issue 290633009: DevTools: Show detailed information for exceptions during snippet execution. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/protocol.json
diff --git a/Source/devtools/protocol.json b/Source/devtools/protocol.json
index 6590315455c27d9f2d0f64277aa7c37acb9572a7..1fc2a2c329da2b9a546bbdb844a8ce3e7c595de5 100644
--- a/Source/devtools/protocol.json
+++ b/Source/devtools/protocol.json
@@ -2959,6 +2959,18 @@
"description": "Scope description."
},
{
+ "id": "ExceptionDetails",
+ "type": "object",
+ "description": "Detailed information on exception (or error) that was thrown during script compilation or execution.",
+ "properties": [
+ { "name": "text", "type": "string", "description": "Exception text." },
+ { "name": "url", "type": "string", "optional": true, "description": "URL of the message origin." },
+ { "name": "line", "type": "integer", "optional": true, "description": "Line number in the resource that generated this message." },
+ { "name": "column", "type": "integer", "optional": true, "description": "Column number in the resource that generated this message." },
+ { "name": "stackTrace", "$ref": "Console.StackTrace", "optional": true, "description": "JavaScript stack trace for assertions and error messages." }
+ ]
+ },
+ {
"id": "SetScriptSourceError",
"type": "object",
"properties": [
@@ -3173,7 +3185,7 @@
],
"returns": [
{ "name": "scriptId", "$ref": "ScriptId", "optional": true, "description": "Id of the script." },
- { "name": "syntaxErrorMessage", "type": "string", "optional": true, "description": "Syntax error message if compilation failed." }
+ { "name": "exceptionDetails", "$ref": "ExceptionDetails", "optional": true, "description": "Exception details."}
],
"description": "Compiles expression."
},
@@ -3188,7 +3200,7 @@
],
"returns": [
{ "name": "result", "$ref": "Runtime.RemoteObject", "description": "Run result." },
- { "name": "wasThrown", "type": "boolean", "optional": true, "description": "True if the result was thrown during the script run." }
+ { "name": "exceptionDetails", "$ref": "ExceptionDetails", "optional": true, "description": "Exception details."}
],
"description": "Runs script with given id in a given context."
},

Powered by Google App Engine
This is Rietveld 408576698