Source/bindings/v8/PageScriptDebugServer.h - Issue 290633009: DevTools: Show detailed information for exceptions during snippet execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/PageScriptDebugServer.h

Issue 290633009: DevTools: Show detailed information for exceptions during snippet execution. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/sources/debugger/debugger-compile-and-run-expected.txt ('k') | Source/bindings/v8/PageScriptDebugServer.cpp » ('j') | Source/devtools/front_end/sdk/ScriptSnippetModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/PageScriptDebugServer.h

diff --git a/Source/bindings/v8/PageScriptDebugServer.h b/Source/bindings/v8/PageScriptDebugServer.h

index dd08816843a41d6a869277812328235e13bdd4ed..7ad2c2ec0e38ed71f7666c8befbd0180a5a7b32b 100644

--- a/Source/bindings/v8/PageScriptDebugServer.h

+++ b/Source/bindings/v8/PageScriptDebugServer.h

@@ -64,9 +64,9 @@ public:

};

void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);

- virtual void compileScript(ScriptState*, const String& expression, const String& sourceURL, String* scriptId, String* exceptionMessage) OVERRIDE;

+ virtual void compileScript(ScriptState*, const String& expression, const String& sourceURL, String* scriptId, String* exceptionDetailsText, int* lineNumber, int* columnNumber, RefPtr<ScriptCallStack>* stackTrace) OVERRIDE;

virtual void clearCompiledScripts() OVERRIDE;

- virtual void runScript(ScriptState*, const String& scriptId, ScriptValue* result, bool* wasThrown, String* exceptionMessage) OVERRIDE;

+ virtual void runScript(ScriptState*, const String& scriptId, ScriptValue* result, bool* wasThrown, String* exceptionDetailsText, int* lineNumber, int* columnNumber, RefPtr<ScriptCallStack>* stackTrace) OVERRIDE;

virtual void setPreprocessorSource(const String&) OVERRIDE;

virtual void preprocessBeforeCompile(const v8::Debug::EventDetails&) OVERRIDE;

virtual PassOwnPtr<ScriptSourceCode> preprocess(LocalFrame*, const ScriptSourceCode&) OVERRIDE;