DevTools: Show detailed information for exceptions during snippet execution.

Source/devtools/front_end/sdk/ScriptSnippetModel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 227 matching lines @@
         var mapping = this._mappingForTarget.get(target);
         mapping._setEvaluationIndex(evaluationIndex, uiSourceCode);
         var evaluationUrl = mapping._evaluationSourceURL(uiSourceCode);
         var expression = uiSourceCode.workingCopy();
         target.consoleModel.show();
         target.debuggerAgent().compileScript(expression, evaluationUrl, executionContext.id, compileCallback.bind(this, target));
 
         /**
          * @param {!WebInspector.Target} target
          * @param {?string} error
-         * @param {string=} scriptId
-         * @param {string=} syntaxErrorMessage
+         * @param {!DebuggerAgent.ScriptId=} scriptId
+         * @param {?DebuggerAgent.ExceptionDetails=} exceptionDetails
          * @this {WebInspector.ScriptSnippetModel}
          */
-        function compileCallback(target, error, scriptId, syntaxErrorMessage)
+        function compileCallback(target, error, scriptId, exceptionDetails)
         {
             if (!uiSourceCode || this._mappingForTarget.get(target).evaluationIndex(uiSourceCode) !== evaluationIndex)
                 return;
 
             if (error) {
                 console.error(error);
                 return;
             }
 
             if (!scriptId) {
-                var consoleMessage = new WebInspector.ConsoleMessage(
-                        target,
-                        WebInspector.ConsoleMessage.MessageSource.JS,
-                        WebInspector.ConsoleMessage.MessageLevel.Error,
-                        syntaxErrorMessage || "");
-                target.consoleModel.addMessage(consoleMessage);
+                this._printRunOrCompileScriptResultFailure(target, exceptionDetails, evaluationUrl);
                 return;
             }
 
             var breakpointLocations = this._removeBreakpoints(uiSourceCode);
             this._restoreBreakpoints(uiSourceCode, breakpointLocations);
 
-            this._runScript(scriptId, executionContext);
+            this._runScript(scriptId, executionContext, evaluationUrl);
         }
     },
 
     /**
      * @param {!DebuggerAgent.ScriptId} scriptId
      * @param {!WebInspector.ExecutionContext} executionContext
+     * @param {?string=} sourceURL
      */
-    _runScript: function(scriptId, executionContext)
+    _runScript: function(scriptId, executionContext, sourceURL)
     {
         var target = executionContext.target();
         target.debuggerAgent().runScript(scriptId, executionContext.id, "console", false, runCallback.bind(this, target));
 
         /**
          * @param {!WebInspector.Target} target
          * @param {?string} error
          * @param {?RuntimeAgent.RemoteObject} result
-         * @param {boolean=} wasThrown
+         * @param {?DebuggerAgent.ExceptionDetails=} exceptionDetails
          * @this {WebInspector.ScriptSnippetModel}
          */
-        function runCallback(target, error, result, wasThrown)
+        function runCallback(target, error, result, exceptionDetails)
         {
             if (error) {
                 console.error(error);
                 return;
             }
 
-            this._printRunScriptResult(target, result, wasThrown);
+            if (!exceptionDetails)
+                this._printRunScriptResult(target, result, sourceURL);
+            else
+                this._printRunOrCompileScriptResultFailure(target, exceptionDetails, sourceURL);
         }
     },
 
     /**
      * @param {!WebInspector.Target} target
      * @param {?RuntimeAgent.RemoteObject} result
-     * @param {boolean=} wasThrown
+     * @param {?string=} sourceURL
      */
-    _printRunScriptResult: function(target, result, wasThrown)
+    _printRunScriptResult: function(target, result, sourceURL)
     {
-        var level = (wasThrown ? WebInspector.ConsoleMessage.MessageLevel.Error : WebInspector.ConsoleMessage.MessageLevel.Log);
-        var message = new WebInspector.ConsoleMessage(target,
+        var consoleMessage = new WebInspector.ConsoleMessage(
+            target,
             WebInspector.ConsoleMessage.MessageSource.JS,
-            level,
+            WebInspector.ConsoleMessage.MessageLevel.Log,
             "",
             undefined,
+            sourceURL,
+            undefined,
             undefined,
             undefined,
-            undefined,
-            undefined,
-            [result]);
-        target.consoleModel.addMessage(message);
+            [result],
+            undefined);
+        target.consoleModel.addMessage(consoleMessage);
     },
 
     /**
+     * @param {!WebInspector.Target} target
+     * @param {?DebuggerAgent.ExceptionDetails=} exceptionDetails
+     * @param {?string=} sourceURL
+     */
+    _printRunOrCompileScriptResultFailure: function(target, exceptionDetails, sourceURL)
+    {
+        var consoleMessage = new WebInspector.ConsoleMessage(
+            target,
+            exceptionDetails.source,
+            WebInspector.ConsoleMessage.MessageLevel.Error,
+            exceptionDetails.text,
+            undefined,
+            sourceURL,
+            exceptionDetails.line,
+            exceptionDetails.column,
+            undefined,
+            undefined,
+            exceptionDetails.stackTrace);

[aandrey, 2014/07/19 13:15:59]

We also need to pass Console.AsyncStackTrace with the exceptionDetails. I can do
this unless you'd like to.

+        target.consoleModel.addMessage(consoleMessage);
+    },
+
+    /**
      * @param {!WebInspector.UISourceCode} uiSourceCode
      * @return {!Array.<!{breakpoint: !WebInspector.BreakpointManager.Breakpoint, uiLocation: !WebInspector.UILocation}>}
      */
     _removeBreakpoints: function(uiSourceCode)
     {
         var breakpointLocations = WebInspector.breakpointManager.breakpointLocationsForUISourceCode(uiSourceCode);
         for (var i = 0; i < breakpointLocations.length; ++i)
             breakpointLocations[i].breakpoint.remove();
         return breakpointLocations;
     },
@@ skipping 325 matching lines @@
         this._model.deleteScriptSnippet(path);
     },
 
     __proto__: WebInspector.ContentProviderBasedProjectDelegate.prototype
 }
 
 /**
  * @type {!WebInspector.ScriptSnippetModel}
  */
 WebInspector.scriptSnippetModel;