Making the gradient click-through in ChromeSigninViewController

ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm

Index: ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
diff --git a/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm b/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
index 79d2da36a926a4451b86a28529852addc06b3fb9..62bf2e75fff4dee2255a4a02a6a53d3e3674c632 100644
--- a/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
+++ b/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
@@ -359,11 +359,7 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
   AssertAuthenticatedIdentityInActiveProfile(nil);
 }
 
-// Tests that signing in, tapping the Settings link on the confirmation screen
-// and closing the Settings correctly leaves the user signed in without any
-// Settings shown.
-// TODO(crbug.com/718023): Re-enable test.
-- (void)DISABLED_testSignInOpenSettings {

[baxley, 2017/06/01 15:36:21]

If you prefix it with FLAKY_ (i.e. s/DISABLED_/FLAKY_), then it will run on our
downstream flaky bots.

[jlebel, 2017/06/02 09:28:25]

Done.

+- (void)testSignInOpenSettings {
   ChromeIdentity* identity = GetFakeIdentity1();
   ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity(
       identity);
@@ -375,11 +371,15 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
 
   // Tap Settings link.
   id<GREYMatcher> settings_link_matcher = grey_allOf(
-      grey_accessibilityLabel(@"Settings"), grey_sufficientlyVisible(), nil);
+      grey_accessibilityLabel(@"Settings"), grey_sufficientlyVisible(),
+      grey_enabled(), grey_interactable(), nil);
+  WaitForMatcher(settings_link_matcher);
   [[EarlGrey selectElementWithMatcher:settings_link_matcher]
       performAction:grey_tap()];
 
-  [[EarlGrey selectElementWithMatcher:NavigationBarDoneButton()]
+  id<GREYMatcher> done_button_matcher = NavigationBarDoneButton();
+  WaitForMatcher(done_button_matcher);
+  [[EarlGrey selectElementWithMatcher:done_button_matcher]
       performAction:grey_tap()];
 
   // All Settings should be gone and user signed in.