Making the gradient click-through in ChromeSigninViewController

ios/chrome/browser/ui/first_run/first_run_egtest.mm

Index: ios/chrome/browser/ui/first_run/first_run_egtest.mm
diff --git a/ios/chrome/browser/ui/first_run/first_run_egtest.mm b/ios/chrome/browser/ui/first_run/first_run_egtest.mm
index 5476786fb4f243401e53bfd9bdc1040b95b4f84c..ef17614d59a18e4ab0e48737b5416112814f7f34 100644
--- a/ios/chrome/browser/ui/first_run/first_run_egtest.mm
+++ b/ios/chrome/browser/ui/first_run/first_run_egtest.mm
@@ -6,6 +6,7 @@
 #import <XCTest/XCTest.h>
 
 #include "base/strings/sys_string_conversions.h"
+#import "base/test/ios/wait_util.h"
 #include "components/metrics/metrics_pref_names.h"
 #include "components/metrics/metrics_reporting_default_state.h"
 #include "components/prefs/pref_member.h"
@@ -215,9 +216,7 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
   AssertAuthenticatedIdentityInActiveProfile(nil);
 }
 
-// Signs in to an account and then taps the Advanced link to go to settings.
-// TODO(crbug.com/718023): Re-enable test.
-- (void)DISABLED_testSignInAndTapSettingsLink {
+- (void)testSignInAndTapSettingsLink {
   ChromeIdentity* identity = GetFakeIdentity();
   ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity(
       identity);
@@ -232,6 +231,10 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
       performAction:grey_tap()];
   AssertAuthenticatedIdentityInActiveProfile(identity);
 
+  // Short delay to allow animation to complete and let time for the "Settings"
+  // label to arrive (issue with flakyness, see crbug.com/718023).
+  base::test::ios::SpinRunLoopWithMaxDelay(base::TimeDelta::FromSecondsD(0.5));

[baxley, 2017/05/31 15:51:29]

Similar to the other comment, could you add in the logic to wait for the
matcher. I'm okay if you just put the code inline. I don't know if we want it in
a shared method, since it may make it to easy for people to use. It should only
be used as a last resort. We have had cases where there were animations that
were running when they shouldn't have, so the tests actually found a bug.

+
   // Tap Settings link.
   id<GREYMatcher> settings_link_matcher = grey_allOf(
       grey_accessibilityLabel(@"Settings"), grey_sufficientlyVisible(), nil);