Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm

Issue 2906313004: Making the gradient click-through in ChromeSigninViewController (Closed)
Patch Set: Fixing dependencies ( Merge) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
diff --git a/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm b/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
index 79d2da36a926a4451b86a28529852addc06b3fb9..12345ca6ce5067a80696d71ec24051ceef4477ff 100644
--- a/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
+++ b/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
@@ -362,8 +362,7 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
// Tests that signing in, tapping the Settings link on the confirmation screen
// and closing the Settings correctly leaves the user signed in without any
// Settings shown.
-// TODO(crbug.com/718023): Re-enable test.
-- (void)DISABLED_testSignInOpenSettings {
+- (void)testSignInOpenSettings {
ChromeIdentity* identity = GetFakeIdentity1();
ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity(
identity);
@@ -376,10 +375,13 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
// Tap Settings link.
id<GREYMatcher> settings_link_matcher = grey_allOf(
grey_accessibilityLabel(@"Settings"), grey_sufficientlyVisible(), nil);
+ WaitForMatcher(settings_link_matcher);
[[EarlGrey selectElementWithMatcher:settings_link_matcher]
performAction:grey_tap()];
- [[EarlGrey selectElementWithMatcher:NavigationBarDoneButton()]
+ id<GREYMatcher> done_button_matcher = NavigationBarDoneButton();
+ WaitForMatcher(done_button_matcher);
+ [[EarlGrey selectElementWithMatcher:done_button_matcher]
performAction:grey_tap()];
// All Settings should be gone and user signed in.
« no previous file with comments | « ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm ('k') | ios/chrome/browser/ui/first_run/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698