Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: ios/clean/chrome/browser/ui/tools/menu_view_controller.mm

Issue 2906313003: [ios clean] ToolsMenu Mediator observes Webstate. (Closed)
Patch Set: Improved comments and test nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
diff --git a/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm b/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
index ef10a233fdb75b5076690e7184afbe557e3e4440..81e8c12339c5a4a35ba6e144275594fe36cfad10 100644
--- a/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
+++ b/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
@@ -83,9 +83,6 @@ const CGFloat kCloseButtonHeight = 44.0;
self.menuScrollView.translatesAutoresizingMaskIntoConstraints = NO;
[self.view addSubview:self.menuScrollView];
- // PLACEHOLDER: Hardcoded value until the mediator observes the Webstate.
- self.currentPageLoading = NO;
-
[self setupCloseMenuButton];
[self setupMenuStackView];
[self setupConstraints];
@@ -253,4 +250,17 @@ const CGFloat kCloseButtonHeight = 44.0;
self.displayOverflowControls = displayOverflowControls;
}
+- (void)setIsLoading:(BOOL)isLoading {
+ self.currentPageLoading = isLoading;
+}
+
+- (void)setCurrentPageLoading:(BOOL)currentPageLoading {
+ _currentPageLoading = currentPageLoading;
+ // If the OverflowButtons have been initialized update their visibility.
+ if (self.toolbarOverflowStackView) {
+ self.toolbarOverflowStackView.reloadButton.hidden = currentPageLoading;
+ self.toolbarOverflowStackView.stopButton.hidden = !currentPageLoading;
+ }
+}
+
@end

Powered by Google App Engine
This is Rietveld 408576698