Replace call sites to BorderValue functions to save the BorderValue construction cost

third_party/WebKit/Source/core/layout/LayoutTable.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
@@ skipping 1171 matching lines @@
   if (!ShouldCollapseBorders())
     return LayoutBlock::BorderStart().ToInt();
 
   // Determined by the first cell of the first row. See the CSS 2.1 spec,
   // section 17.6.2.
   if (!NumEffectiveColumns())
     return 0;
 
   int border_width = 0;
 
-  const BorderValue& table_start_border = Style()->BorderStart();
-  if (table_start_border.Style() == EBorderStyle::kHidden)
+  EBorderStyle table_start_border_style = Style()->BorderStartStyle();
+  if (table_start_border_style == EBorderStyle::kHidden)
     return 0;
-  if (ComputedStyle::BorderStyleIsVisible(table_start_border.Style()))
-    border_width = table_start_border.Width();
+  if (ComputedStyle::BorderStyleIsVisible(table_start_border_style))
+    border_width = Style()->BorderStartWidth();
 
   // TODO(dgrogan): This logic doesn't properly account for the first column in
   // the first column-group case.
   if (LayoutTableCol* column =
           ColElementAtAbsoluteColumn(0).InnermostColOrColGroup()) {
     // FIXME: We don't account for direction on columns and column groups.
-    const BorderValue& column_adjoining_border = column->Style()->BorderStart();
-    if (column_adjoining_border.Style() == EBorderStyle::kHidden)
+    EBorderStyle column_adjoining_border_style =
+        column->Style()->BorderStartStyle();
+    if (column_adjoining_border_style == EBorderStyle::kHidden)
       return 0;
-    if (ComputedStyle::BorderStyleIsVisible(column_adjoining_border.Style()))
+    if (ComputedStyle::BorderStyleIsVisible(column_adjoining_border_style)) {
       border_width =
-          std::max<int>(border_width, column_adjoining_border.Width());
+          std::max<int>(border_width, column->Style()->BorderStartWidth());
+    }
   }
 
   if (const LayoutTableSection* top_non_empty_section =
           this->TopNonEmptySection()) {
     const BorderValue& section_adjoining_border =
         top_non_empty_section->BorderAdjoiningTableStart();
     if (section_adjoining_border.Style() == EBorderStyle::kHidden)
       return 0;
 
     if (ComputedStyle::BorderStyleIsVisible(section_adjoining_border.Style()))
@@ skipping 32 matching lines @@
   if (!ShouldCollapseBorders())
     return LayoutBlock::BorderEnd().ToInt();
 
   // Determined by the last cell of the first row. See the CSS 2.1 spec, section
   // 17.6.2.
   if (!NumEffectiveColumns())
     return 0;
 
   int border_width = 0;
 
-  const BorderValue& table_end_border = Style()->BorderEnd();
-  if (table_end_border.Style() == EBorderStyle::kHidden)
+  EBorderStyle table_end_border_style = Style()->BorderEndStyle();
+  if (table_end_border_style == EBorderStyle::kHidden)
     return 0;
-  if (ComputedStyle::BorderStyleIsVisible(table_end_border.Style()))
-    border_width = table_end_border.Width();
+  if (ComputedStyle::BorderStyleIsVisible(table_end_border_style))
+    border_width = Style()->BorderEndWidth();
 
   unsigned end_column = NumEffectiveColumns() - 1;
 
   // TODO(dgrogan): This logic doesn't properly account for the last column in
   // the last column-group case.
   if (LayoutTableCol* column =
           ColElementAtAbsoluteColumn(end_column).InnermostColOrColGroup()) {
     // FIXME: We don't account for direction on columns and column groups.
-    const BorderValue& column_adjoining_border = column->Style()->BorderEnd();
-    if (column_adjoining_border.Style() == EBorderStyle::kHidden)
+    EBorderStyle column_adjoining_border_style =
+        column->Style()->BorderEndStyle();
+    if (column_adjoining_border_style == EBorderStyle::kHidden)
       return 0;
-    if (ComputedStyle::BorderStyleIsVisible(column_adjoining_border.Style()))
+    if (ComputedStyle::BorderStyleIsVisible(column_adjoining_border_style)) {
       border_width =
-          std::max<int>(border_width, column_adjoining_border.Width());
+          std::max<int>(border_width, column->Style()->BorderEndWidth());
+    }
   }
 
   if (const LayoutTableSection* top_non_empty_section =
           this->TopNonEmptySection()) {
     const BorderValue& section_adjoining_border =
         top_non_empty_section->BorderAdjoiningTableEnd();
     if (section_adjoining_border.Style() == EBorderStyle::kHidden)
       return 0;
 
     if (ComputedStyle::BorderStyleIsVisible(section_adjoining_border.Style()))
@@ skipping 53 matching lines @@
 
 int LayoutTable::OuterBorderBefore() const {
   if (!ShouldCollapseBorders())
     return 0;
   int border_width = 0;
   if (LayoutTableSection* top_section = this->TopSection()) {
     border_width = top_section->OuterBorderBefore();
     if (border_width < 0)
       return 0;  // Overridden by hidden
   }
-  const BorderValue& tb = Style()->BorderBefore();
-  if (tb.Style() == EBorderStyle::kHidden)
+  EBorderStyle tbs = Style()->BorderBeforeStyle();
+  if (tbs == EBorderStyle::kHidden)
     return 0;
-  if (ComputedStyle::BorderStyleIsVisible(tb.Style()))
-    border_width = std::max<int>(border_width, tb.Width() / 2);
+  if (ComputedStyle::BorderStyleIsVisible(tbs)) {
+    border_width =
+        std::max<int>(border_width, Style()->BorderBeforeWidth() / 2);
+  }
   return border_width;
 }
 
 int LayoutTable::OuterBorderAfter() const {
   if (!ShouldCollapseBorders())
     return 0;
   int border_width = 0;
 
   if (LayoutTableSection* section = BottomSection()) {
     border_width = section->OuterBorderAfter();
     if (border_width < 0)
       return 0;  // Overridden by hidden
   }
-  const BorderValue& tb = Style()->BorderAfter();
-  if (tb.Style() == EBorderStyle::kHidden)
+  EBorderStyle tbs = Style()->BorderAfterStyle();
+  if (tbs == EBorderStyle::kHidden)
     return 0;
-  if (ComputedStyle::BorderStyleIsVisible(tb.Style()))
-    border_width = std::max<int>(border_width, (tb.Width() + 1) / 2);
+  if (ComputedStyle::BorderStyleIsVisible(tbs)) {
+    border_width =
+        std::max<int>(border_width, (Style()->BorderAfterWidth() + 1) / 2);
+  }
   return border_width;
 }
 
 int LayoutTable::OuterBorderStart() const {
   if (!ShouldCollapseBorders())
     return 0;
 
   int border_width = 0;
 
-  const BorderValue& tb = Style()->BorderStart();
-  if (tb.Style() == EBorderStyle::kHidden)
+  EBorderStyle tbs = Style()->BorderStartStyle();
+  if (tbs == EBorderStyle::kHidden)
     return 0;
-  if (ComputedStyle::BorderStyleIsVisible(tb.Style()))
-    border_width =
-        (tb.Width() + (Style()->IsLeftToRightDirection() ? 0 : 1)) / 2;
+  if (ComputedStyle::BorderStyleIsVisible(tbs)) {
+    border_width = (Style()->BorderStartWidth() +
+                    (Style()->IsLeftToRightDirection() ? 0 : 1)) /
+                   2;
+  }
 
   bool all_hidden = true;
   for (LayoutTableSection* section = TopSection(); section;
        section = SectionBelow(section)) {
     int sw = section->OuterBorderStart();
     if (sw < 0)
       continue;
     all_hidden = false;
     border_width = std::max(border_width, sw);
   }
   if (all_hidden)
     return 0;
 
   return border_width;
 }
 
 int LayoutTable::OuterBorderEnd() const {
   if (!ShouldCollapseBorders())
     return 0;
 
   int border_width = 0;
 
-  const BorderValue& tb = Style()->BorderEnd();
-  if (tb.Style() == EBorderStyle::kHidden)
+  EBorderStyle tbs = Style()->BorderEndStyle();
+  if (tbs == EBorderStyle::kHidden)
     return 0;
-  if (ComputedStyle::BorderStyleIsVisible(tb.Style()))
-    border_width =
-        (tb.Width() + (Style()->IsLeftToRightDirection() ? 1 : 0)) / 2;
+  if (ComputedStyle::BorderStyleIsVisible(tbs)) {
+    border_width = (Style()->BorderEndWidth() +
+                    (Style()->IsLeftToRightDirection() ? 1 : 0)) /
+                   2;
+  }
 
   bool all_hidden = true;
   for (LayoutTableSection* section = TopSection(); section;
        section = SectionBelow(section)) {
     int sw = section->OuterBorderEnd();
     if (sw < 0)
       continue;
     all_hidden = false;
     border_width = std::max(border_width, sw);
   }
@@ skipping 335 matching lines @@
 }
 
 LayoutUnit LayoutTable::PaddingRight() const {
   if (ShouldCollapseBorders())
     return LayoutUnit();
 
   return LayoutBlock::PaddingRight();
 }
 
 }  // namespace blink