Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: components/captive_portal/captive_portal_detector.cc

Issue 2906233005: Deprecate NonThreadSafe in components/captive_portal in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/captive_portal/captive_portal_detector.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/captive_portal/captive_portal_detector.cc
diff --git a/components/captive_portal/captive_portal_detector.cc b/components/captive_portal/captive_portal_detector.cc
index 6ec4df23d667ab2c24811ca9f7d84efd42a6c9ac..a51b809164ae1be9bda0d635851d7d4dc94124bf 100644
--- a/components/captive_portal/captive_portal_detector.cc
+++ b/components/captive_portal/captive_portal_detector.cc
@@ -23,13 +23,14 @@ CaptivePortalDetector::CaptivePortalDetector(
}
CaptivePortalDetector::~CaptivePortalDetector() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
}
void CaptivePortalDetector::DetectCaptivePortal(
const GURL& url,
const DetectionCallback& detection_callback,
const net::NetworkTrafficAnnotationTag& traffic_annotation) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK(!FetchingURL());
DCHECK(detection_callback_.is_null());
@@ -60,7 +61,7 @@ void CaptivePortalDetector::Cancel() {
}
void CaptivePortalDetector::OnURLFetchComplete(const net::URLFetcher* source) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK(FetchingURL());
DCHECK_EQ(url_fetcher_.get(), source);
DCHECK(!detection_callback_.is_null());
« no previous file with comments | « components/captive_portal/captive_portal_detector.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698