[OriginChip] Re-enable the chip if the text changes during an Update().

[OriginChip] Re-enable the chip if the text changes during an Update().

Note that the outcome now in the case where you click the chip and then the back button is that the Omnibox retains focus but the chip is shown.  We normally don't allow this but it's analogous to the non-origin-chip behavior in this case.

BUG=371684
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271177

[Peter Kasting, 2014-05-15 22:57:04]

When I hit the back button on my mouse, the origin chip reappears and the
omnibox does not retain focus.

I would expect the back button in the toolbar to do the same thing.  So it seems
like the biggest problem here is that toolbar back/forward are not resetting
focus the way the mouse back/forward are.

This would also avoid the weird state you mention.

[Justin Donnelly, 2014-05-16 00:07:57]

On 2014/05/15 22:57:04, Peter Kasting wrote:
> When I hit the back button on my mouse, the origin chip reappears and the
> omnibox does not retain focus.
> 
> I would expect the back button in the toolbar to do the same thing.  So it
seems
> like the biggest problem here is that toolbar back/forward are not resetting
> focus the way the mouse back/forward are.
> 
> This would also avoid the weird state you mention.

I don't have access to a mouse with a working back button at the moment.  Is the
behavior the same as that produced by alt-left?  Also, is the state you end up
in "invisible focus"?  In other words, if you start typing does the output
appear in the Omnibox?  If not, where does the focus go?

[Peter Kasting, 2014-05-16 00:12:22]

On 2014/05/16 00:07:57, Justin Donnelly wrote:
> On 2014/05/15 22:57:04, Peter Kasting wrote:
> > When I hit the back button on my mouse, the origin chip reappears and the
> > omnibox does not retain focus.
> > 
> > I would expect the back button in the toolbar to do the same thing.  So it
> seems
> > like the biggest problem here is that toolbar back/forward are not resetting
> > focus the way the mouse back/forward are.
> > 
> > This would also avoid the weird state you mention.
> 
> I don't have access to a mouse with a working back button at the moment.  Is
the
> behavior the same as that produced by alt-left?

No.  Alt-left is like pressing the toolbar button.

> Also, is the state you end up
> in "invisible focus"?  In other words, if you start typing does the output
> appear in the Omnibox?

No.

> If not, where does the focus go?

To the page, as it does when we e.g. load some page.

[Justin Donnelly, 2014-05-16 19:36:58]

On 2014/05/16 00:12:22, Peter Kasting wrote:
> On 2014/05/16 00:07:57, Justin Donnelly wrote:
> > On 2014/05/15 22:57:04, Peter Kasting wrote:
> > > When I hit the back button on my mouse, the origin chip reappears and the
> > > omnibox does not retain focus.
> > > 
> > > I would expect the back button in the toolbar to do the same thing.  So it
> > seems
> > > like the biggest problem here is that toolbar back/forward are not
resetting
> > > focus the way the mouse back/forward are.
> > > 
> > > This would also avoid the weird state you mention.
> > 
> > I don't have access to a mouse with a working back button at the moment.  Is
> the
> > behavior the same as that produced by alt-left?
> 
> No.  Alt-left is like pressing the toolbar button.
> 
> > Also, is the state you end up
> > in "invisible focus"?  In other words, if you start typing does the output
> > appear in the Omnibox?
> 
> No.
> 
> > If not, where does the focus go?
> 
> To the page, as it does when we e.g. load some page.

Based on the discussion in the associated bug, it sounds like we want to change
the focus behavior in a more fundamental way (and not limited to when the origin
chip experiment is enabled).  Until I come up with a proposal for how to do
that, any objection to this change as an interim fix for the issue?  Ending up
in the state where the omnibox has focus at the same time as the origin chip is
visible is not ideal but better than the current behavior where neither the
origin chip nor URL is visible as you navigate.

[Peter Kasting, 2014-05-16 20:37:01]

LGTM

[Justin Donnelly, 2014-05-16 20:59:36]

The CQ bit was checked by jdonnelly@chromium.org

[commit-bot: I haz the power, 2014-05-16 21:00:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdonnelly@chromium.org/290623002/1

[commit-bot: I haz the power, 2014-05-17 05:27:24]

Change committed as 271177