Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2906193004: improve fasta unterminated string recovery (Closed)

Created:
3 years, 6 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

improve fasta unterminated string recovery * enhance handling of unterminated strings * update ast builder and string validator to handle unterminated strings Committed: https://github.com/dart-lang/sdk/commit/6907345fb9323203a5cf78ce9bdc383cf1a299de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -143 lines) Patch
M pkg/compiler/lib/src/string_validator.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/quote.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 6 chunks +35 lines, -16 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M pkg/front_end/test/scanner_fasta_test.dart View 4 chunks +114 lines, -68 lines 0 comments Download
M pkg/front_end/test/scanner_replacement_test.dart View 3 chunks +0 lines, -42 lines 0 comments Download
M pkg/front_end/test/scanner_test.dart View 5 chunks +65 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
3 years, 6 months ago (2017-05-27 12:37:34 UTC) #2
danrubel
Committed patchset #1 (id:1) manually as 6907345fb9323203a5cf78ce9bdc383cf1a299de (presubmit successful).
3 years, 6 months ago (2017-05-29 03:35:39 UTC) #4
ahe
I think this was accidentally submitted and then immediately reverted.
3 years, 6 months ago (2017-05-29 13:43:00 UTC) #5
danrubel
3 years, 6 months ago (2017-05-30 09:54:21 UTC) #6
Message was sent while issue was closed.
On 2017/05/29 13:43:00, ahe wrote:
> I think this was accidentally submitted and then immediately reverted.

Correct. Reverted
https://github.com/dart-lang/sdk/commit/767d5ecbfd883fcfe506e67511d97f1601f42031

Powered by Google App Engine
This is Rietveld 408576698