[network service][SW] Rework browser-side SW on top of URL loader chaining

content/browser/service_worker/service_worker_version.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_version.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 24 matching lines @@
 #include "content/browser/service_worker/service_worker_metrics.h"
 #include "content/browser/service_worker/service_worker_registration.h"
 #include "content/common/origin_trials/trial_token_validator.h"
 #include "content/common/service_worker/embedded_worker_messages.h"
 #include "content/common/service_worker/embedded_worker_start_params.h"
 #include "content/common/service_worker/service_worker_messages.h"
 #include "content/common/service_worker/service_worker_utils.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/render_process_host.h"
+#include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/result_codes.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_response_info.h"
 #include "third_party/WebKit/public/web/WebConsoleMessage.h"
 
 namespace content {
 
 using StatusCallback = ServiceWorkerVersion::StatusCallback;
@@ skipping 841 matching lines @@
 
 void ServiceWorkerVersion::OnDetached(EmbeddedWorkerStatus old_status) {
   if (IsInstalled(status())) {
     ServiceWorkerMetrics::RecordWorkerStopped(
         ServiceWorkerMetrics::StopStatus::DETACH_BY_REGISTRY);
   }
   OnStoppedInternal(old_status);
 }
 
 void ServiceWorkerVersion::OnScriptLoaded() {
-  DCHECK(GetMainScriptHttpResponseInfo());
+  DCHECK(GetMainScriptHttpResponseInfo() ||
+         // TODO(scottmg|falken): This DCHECK is currently triggered in
+         // --network-service because subresources haven't been implemented yet.

[falken, 2017/06/06 13:20:23]

In the non-servicifiied path,  ServiceWorkerReadFromCacheJob would set the http
response info. So, if this DCHECK is now failing, it's not really that
subresources are not implemented, it's that the service worker script reading is
not implemented.

In the servicified path, I'm a bit surprised that the service worker is able to
start at all if ServiceWorkerReadFromCacheJob is not being used. I guess it's
because we are fetching the service worker from network each time.

[scottmg, 2017/06/06 16:50:09]

I see. OK, I updated the comment. I think I got confused between the fetch of
the contents of index.html and the retrieval of the service worker js itself.

I'll continue with this as-is to avoid making this CL even messier, and then we
can look at whether to reuse ServiceWorkerReadFromCacheJob or implement
something similar.

+         // This should be removed once that is complete.
+         (IsBrowserSideNavigationEnabled() &&
+          base::CommandLine::ForCurrentProcess()->HasSwitch(
+              switches::kEnableNetworkService)));
   if (IsInstalled(status()))
     UMA_HISTOGRAM_BOOLEAN("ServiceWorker.ScriptLoadSuccess", true);
 }
 
 void ServiceWorkerVersion::OnScriptLoadFailed() {
   if (IsInstalled(status()))
     UMA_HISTOGRAM_BOOLEAN("ServiceWorker.ScriptLoadSuccess", false);
 }
 
 void ServiceWorkerVersion::OnRegisteredToDevToolsManager() {
@@ skipping 924 matching lines @@
 
 void ServiceWorkerVersion::CleanUpExternalRequest(
     const std::string& request_uuid,
     ServiceWorkerStatusCode status) {
   if (status == SERVICE_WORKER_OK)
     return;
   external_request_uuid_to_request_id_.erase(request_uuid);
 }
 
 }  // namespace content