[inspector] Support multiple sessions per context group

src/inspector/inspected-context.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INSPECTOR_INSPECTEDCONTEXT_H_
 #define V8_INSPECTOR_INSPECTEDCONTEXT_H_
 
+#include <map>
+
 #include "src/base/macros.h"
 #include "src/inspector/string-16.h"
 
 #include "include/v8.h"
 
 namespace v8_inspector {
 
 class InjectedScript;
 class InjectedScriptHost;
 class V8ContextInfo;
 class V8InspectorImpl;
 
 class InspectedContext {
  public:
   ~InspectedContext();
 
   static int contextId(v8::Local<v8::Context>);
 
   v8::Local<v8::Context> context() const;
   int contextId() const { return m_contextId; }
   int contextGroupId() const { return m_contextGroupId; }
   String16 origin() const { return m_origin; }
   String16 humanReadableName() const { return m_humanReadableName; }
   String16 auxData() const { return m_auxData; }
 
-  bool isReported() const { return m_reported; }
-  void setReported(bool reported) { m_reported = reported; }
+  bool isReported(int session_id) { return m_reported[session_id]; }

[kozy, 2017/06/01 09:43:45]

auto it = m_reported.find(session_id);
return it != m_reported.end() && *it;

to save a const :)

[dgozman, 2017/06/01 21:04:59]

Done.

+  void setReported(int session_id, bool reported) {
+    m_reported[session_id] = reported;
+  }
 
   v8::Isolate* isolate() const;
   V8InspectorImpl* inspector() const { return m_inspector; }
 
   InjectedScript* getInjectedScript() { return m_injectedScript.get(); }
   bool createInjectedScript();
   void discardInjectedScript();
 
  private:
   friend class V8InspectorImpl;
   InspectedContext(V8InspectorImpl*, const V8ContextInfo&, int contextId);
 
   V8InspectorImpl* m_inspector;
   v8::Global<v8::Context> m_context;
   int m_contextId;
   int m_contextGroupId;
   const String16 m_origin;
   const String16 m_humanReadableName;
   const String16 m_auxData;
-  bool m_reported;
+  std::map<int, bool> m_reported;

[kozy, 2017/06/01 09:43:45]

can it be a set of session_ids where context was reported?

[dgozman, 2017/06/01 16:06:48]

Totally!

   std::unique_ptr<InjectedScript> m_injectedScript;
 
   DISALLOW_COPY_AND_ASSIGN(InspectedContext);
 };
 
 }  // namespace v8_inspector
 
 #endif  // V8_INSPECTOR_INSPECTEDCONTEXT_H_