Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: content/public/browser/web_contents.h

Issue 2906133004: JavaScript dialogs cause a page to lose fullscreen. (Closed)
Patch Set: with a test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 721 matching lines...) Expand 10 before | Expand all | Expand 10 after
732 732
733 // The callback invoked when the renderer responds to a request for the main 733 // The callback invoked when the renderer responds to a request for the main
734 // frame document's manifest. The url will be empty if the document specifies 734 // frame document's manifest. The url will be empty if the document specifies
735 // no manifest, and the manifest will be empty if any other failures occurred. 735 // no manifest, and the manifest will be empty if any other failures occurred.
736 typedef base::Callback<void(const GURL&, const Manifest&)> 736 typedef base::Callback<void(const GURL&, const Manifest&)>
737 GetManifestCallback; 737 GetManifestCallback;
738 738
739 // Requests the manifest URL and the Manifest of the main frame's document. 739 // Requests the manifest URL and the Manifest of the main frame's document.
740 virtual void GetManifest(const GetManifestCallback& callback) = 0; 740 virtual void GetManifest(const GetManifestCallback& callback) = 0;
741 741
742 // Returns whether the renderer is in fullscreen mode.
743 virtual bool IsFullscreenForCurrentTab() const = 0;
Matt Giuca 2017/06/09 06:16:37 Hmmm... It's a bit weird to have the same method i
Avi (use Gerrit) 2017/06/09 14:36:23 Yes, this is done in a few places.
744
742 // Requests the renderer to exit fullscreen. 745 // Requests the renderer to exit fullscreen.
743 // |will_cause_resize| indicates whether the fullscreen change causes a 746 // |will_cause_resize| indicates whether the fullscreen change causes a
744 // view resize. e.g. This will be false when going from tab fullscreen to 747 // view resize. e.g. This will be false when going from tab fullscreen to
745 // browser fullscreen. 748 // browser fullscreen.
746 virtual void ExitFullscreen(bool will_cause_resize) = 0; 749 virtual void ExitFullscreen(bool will_cause_resize) = 0;
747 750
748 // Unblocks requests from renderer for a newly created window. This is 751 // Unblocks requests from renderer for a newly created window. This is
749 // used in showCreatedWindow() or sometimes later in cases where 752 // used in showCreatedWindow() or sometimes later in cases where
750 // delegate->ShouldResumeRequestsForCreatedWindow() indicated the requests 753 // delegate->ShouldResumeRequestsForCreatedWindow() indicated the requests
751 // should not yet be resumed. Then the client is responsible for calling this 754 // should not yet be resumed. Then the client is responsible for calling this
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
822 825
823 private: 826 private:
824 // This interface should only be implemented inside content. 827 // This interface should only be implemented inside content.
825 friend class WebContentsImpl; 828 friend class WebContentsImpl;
826 WebContents() {} 829 WebContents() {}
827 }; 830 };
828 831
829 } // namespace content 832 } // namespace content
830 833
831 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 834 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698