Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/perf/benchmarks/memory.py

Issue 2906113002: [draft] Modifying telemetry to collect memory dumps over a large set of sites
Patch Set: refactor Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/desktop_memory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/memory.py
diff --git a/tools/perf/benchmarks/memory.py b/tools/perf/benchmarks/memory.py
index 889e0542b397ed8f9d3613fddc3067eee2673544..86f883d29ce76f531891467b7aaae35776c0c554 100644
--- a/tools/perf/benchmarks/memory.py
+++ b/tools/perf/benchmarks/memory.py
@@ -84,6 +84,45 @@ class MemoryBenchmarkTrivialSitesDesktop(_MemoryInfra):
return not _IGNORED_STATS_RE.search(value.name)
+@benchmark.Enabled('mac')
+@benchmark.Enabled('win')
+@benchmark.Owner(emails=['erikchen@chromium.org'])
+class MemoryBenchmarkSitesDesktop(_MemoryInfra):
+ """Measure memory usage on popular sites."""
+ options = {'pageset_repeat': 3}
+
+ def CreateStorySet(self, options):
+ return page_sets.DesktopMemoryPageSet()
+
+ def SetExtraBrowserOptions(self, options):
+ super(MemoryBenchmarkSitesDesktop, self).SetExtraBrowserOptions(
+ options)
+ options.AppendExtraBrowserArgs([
+ '--enable-heap-profiling=native',
+ ])
+ # Disablr taking screen shot on failed pages for all perf benchmarks.
+ options.take_screenshot_for_failed_page = False
+
+ @classmethod
+ def Name(cls):
+ return 'memory.desktop_sites'
+
+ @classmethod
+ def ShouldTearDownStateAfterEachStoryRun(cls):
+ return False
+
+ @classmethod
+ def ShouldTearDownStateAfterEachStorySetRun(cls):
+ return False
+
+ @classmethod
+ def ValueCanBeAddedPredicate(cls, value, is_first_result):
+ # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
+ # is able to cope with the data load generated by TBMv2 metrics.
+ return not _IGNORED_STATS_RE.search(value.name)
+
+
+
@benchmark.Enabled('android') # catapult:#3176
@benchmark.Owner(emails=['perezju@chromium.org'])
class MemoryBenchmarkTop10Mobile(_MemoryInfra):
« no previous file with comments | « no previous file | tools/perf/page_sets/desktop_memory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698