Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Side by Side Diff: chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.cc

Issue 2906103002: Post-cleanup settings reset. (Closed)
Patch Set: Code reviews Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_ win.h" 5 #include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_ win.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/files/file_util.h" 12 #include "base/files/file_util.h"
13 #include "base/location.h" 13 #include "base/location.h"
14 #include "base/logging.h" 14 #include "base/logging.h"
15 #include "base/memory/ptr_util.h" 15 #include "base/memory/ptr_util.h"
16 #include "base/memory/singleton.h" 16 #include "base/memory/singleton.h"
17 #include "base/task_scheduler/post_task.h" 17 #include "base/task_scheduler/post_task.h"
18 #include "base/task_scheduler/task_traits.h" 18 #include "base/task_scheduler/task_traits.h"
19 #include "base/threading/thread_restrictions.h" 19 #include "base/threading/thread_restrictions.h"
20 #include "base/threading/thread_task_runner_handle.h" 20 #include "base/threading/thread_task_runner_handle.h"
21 #include "chrome/browser/browser_process.h"
21 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h" 22 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
23 #include "chrome/browser/profiles/profile.h"
24 #include "chrome/browser/profiles/profile_manager.h"
22 #include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_fetcher_win .h" 25 #include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_fetcher_win .h"
23 #include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win. h" 26 #include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win. h"
27 #include "chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.h"
24 #include "chrome/browser/safe_browsing/chrome_cleaner/srt_client_info_win.h" 28 #include "chrome/browser/safe_browsing/chrome_cleaner/srt_client_info_win.h"
25 #include "components/chrome_cleaner/public/constants/constants.h" 29 #include "components/chrome_cleaner/public/constants/constants.h"
26 #include "components/safe_browsing/common/safe_browsing_prefs.h" 30 #include "components/safe_browsing/common/safe_browsing_prefs.h"
27 #include "content/public/browser/browser_thread.h" 31 #include "content/public/browser/browser_thread.h"
28 #include "net/http/http_status_code.h" 32 #include "net/http/http_status_code.h"
29 33
30 namespace safe_browsing { 34 namespace safe_browsing {
31 35
32 namespace { 36 namespace {
33 37
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 107
104 bool ChromeCleanerControllerDelegate:: 108 bool ChromeCleanerControllerDelegate::
105 SafeBrowsingExtendedReportingScoutEnabled() { 109 SafeBrowsingExtendedReportingScoutEnabled() {
106 return safe_browsing::SafeBrowsingExtendedReportingScoutEnabled(); 110 return safe_browsing::SafeBrowsingExtendedReportingScoutEnabled();
107 } 111 }
108 112
109 bool ChromeCleanerControllerDelegate::IsMetricsAndCrashReportingEnabled() { 113 bool ChromeCleanerControllerDelegate::IsMetricsAndCrashReportingEnabled() {
110 return ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled(); 114 return ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled();
111 } 115 }
112 116
117 void ChromeCleanerControllerDelegate::InvokeTagForResetting(Profile* profile) {
118 std::unique_ptr<PostCleanupSettingsResetter> resetter(
119 PostCleanupSettingsResetter::Create());
robertshield 2017/06/12 15:00:04 Create() is documented as returning null if resett
ftirelo 2017/06/13 18:52:48 Simplified the interface as suggested.
120 resetter->TagForResetting(profile);
121 }
122
123 void ChromeCleanerControllerDelegate::InvokeResetTaggedProfiles(
124 std::vector<Profile*> profiles,
125 base::OnceClosure continuation) {
126 std::unique_ptr<PostCleanupSettingsResetter> resetter(
127 PostCleanupSettingsResetter::Create());
128 resetter->ResetTaggedProfiles(std::move(profiles), std::move(continuation));
129 }
130
113 // static 131 // static
114 ChromeCleanerController* ChromeCleanerController::GetInstance() { 132 ChromeCleanerController* ChromeCleanerController::GetInstance() {
115 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 133 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
116 return base::Singleton<ChromeCleanerController>::get(); 134 return base::Singleton<ChromeCleanerController>::get();
117 } 135 }
118 136
119 void ChromeCleanerController::SetDelegateForTesting( 137 void ChromeCleanerController::SetDelegateForTesting(
120 ChromeCleanerControllerDelegate* delegate) { 138 ChromeCleanerControllerDelegate* delegate) {
121 DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); 139 DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
122 delegate_ = delegate ? delegate : real_delegate_.get(); 140 delegate_ = delegate ? delegate : real_delegate_.get();
(...skipping 29 matching lines...) Expand all
152 DCHECK(!reporter_invocation_); 170 DCHECK(!reporter_invocation_);
153 reporter_invocation_ = 171 reporter_invocation_ =
154 base::MakeUnique<SwReporterInvocation>(reporter_invocation); 172 base::MakeUnique<SwReporterInvocation>(reporter_invocation);
155 SetStateAndNotifyObservers(State::kScanning); 173 SetStateAndNotifyObservers(State::kScanning);
156 delegate_->FetchAndVerifyChromeCleaner(base::BindOnce( 174 delegate_->FetchAndVerifyChromeCleaner(base::BindOnce(
157 &ChromeCleanerController::OnChromeCleanerFetchedAndVerified, 175 &ChromeCleanerController::OnChromeCleanerFetchedAndVerified,
158 base::Unretained(this))); 176 base::Unretained(this)));
159 } 177 }
160 178
161 void ChromeCleanerController::ReplyWithUserResponse( 179 void ChromeCleanerController::ReplyWithUserResponse(
180 Profile* profile,
162 UserResponse user_response) { 181 UserResponse user_response) {
163 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 182 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
164 DCHECK(prompt_user_callback_); 183 DCHECK(prompt_user_callback_);
165 184
166 if (state() != State::kInfected) 185 if (state() != State::kInfected)
167 return; 186 return;
168 187
169 PromptAcceptance acceptance = PromptAcceptance::DENIED; 188 PromptAcceptance acceptance = PromptAcceptance::DENIED;
170 State new_state = State::kIdle; 189 State new_state = State::kIdle;
171 switch (user_response) { 190 switch (user_response) {
172 case UserResponse::kAccepted: 191 case UserResponse::kAccepted:
173 acceptance = PromptAcceptance::ACCEPTED; 192 acceptance = PromptAcceptance::ACCEPTED;
174 new_state = State::kCleaning; 193 new_state = State::kCleaning;
194 delegate_->InvokeTagForResetting(profile);
175 break; 195 break;
176 case UserResponse::kDenied: // Fallthrough 196 case UserResponse::kDenied: // Fallthrough
177 case UserResponse::kDismissed: 197 case UserResponse::kDismissed:
178 acceptance = PromptAcceptance::DENIED; 198 acceptance = PromptAcceptance::DENIED;
179 idle_reason_ = IdleReason::kUserDeclinedCleanup; 199 idle_reason_ = IdleReason::kUserDeclinedCleanup;
180 new_state = State::kIdle; 200 new_state = State::kIdle;
181 break; 201 break;
182 } 202 }
183 203
184 BrowserThread::GetTaskRunnerForThread(BrowserThread::IO) 204 BrowserThread::GetTaskRunnerForThread(BrowserThread::IO)
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 SetStateAndNotifyObservers(State::kIdle); 380 SetStateAndNotifyObservers(State::kIdle);
361 return; 381 return;
362 } 382 }
363 383
364 if (process_status.exit_code == kRebootRequiredExitCode) { 384 if (process_status.exit_code == kRebootRequiredExitCode) {
365 SetStateAndNotifyObservers(State::kRebootRequired); 385 SetStateAndNotifyObservers(State::kRebootRequired);
366 return; 386 return;
367 } 387 }
368 388
369 if (process_status.exit_code == kRebootNotRequiredExitCode) { 389 if (process_status.exit_code == kRebootNotRequiredExitCode) {
370 idle_reason_ = IdleReason::kCleaningSucceeded; 390 delegate_->InvokeResetTaggedProfiles(
371 SetStateAndNotifyObservers(State::kIdle); 391 g_browser_process->profile_manager()->GetLoadedProfiles(),
392 base::BindOnce(&ChromeCleanerController::OnSettingsResetCompleted,
393 base::Unretained(this)));
372 return; 394 return;
373 } 395 }
374 396
375 idle_reason_ = IdleReason::kCleaningFailed; 397 idle_reason_ = IdleReason::kCleaningFailed;
376 SetStateAndNotifyObservers(State::kIdle); 398 SetStateAndNotifyObservers(State::kIdle);
377 } 399 }
378 400
401 void ChromeCleanerController::OnSettingsResetCompleted() {
402 idle_reason_ = IdleReason::kCleaningSucceeded;
403 SetStateAndNotifyObservers(State::kIdle);
404 }
405
379 } // namespace safe_browsing 406 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698