Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: dm/DM.cpp

Issue 290603002: Generate Android.mk for DM. (Closed) Base URL: https://skia.googlesource.com/skia.git@generate_gm
Patch Set: Remove one more generated file. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dm/DMExpectations.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index f4eefa685cda8296f28c9338d59885136a4928ce..8df0ab101f37bce5670d5071a80b988849cc609c 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -21,7 +21,7 @@
#include "DMTestTask.h"
#include "DMWriteTask.h"
-#include <string.h>
+#include <ctype.h>
using skiagm::GM;
using skiagm::GMRegistry;
@@ -32,7 +32,10 @@ DEFINE_int32(threads, -1, "Threads for CPU work. Default NUM_CPUS.");
DEFINE_int32(gpuThreads, 1, "Threads for GPU work.");
DEFINE_string2(expectations, r, "",
"If a directory, compare generated images against images under this path. "
- "If a file, compare generated images against JSON expectations at this path.");
+#ifdef SK_BUILD_JSON_WRITER
+ "If a file, compare generated images against JSON expectations at this path."
+#endif
+);
DEFINE_string2(resources, i, "resources", "Path to resources directory.");
DEFINE_string(match, "", "[~][^]substring[$] [...] of GM name to run.\n"
"Multiple matches may be separated by spaces.\n"
@@ -225,7 +228,9 @@ int tool_main(int argc, char** argv) {
if (sk_isdir(path)) {
expectations.reset(SkNEW_ARGS(DM::WriteTask::Expectations, (path)));
} else {
+#ifdef SK_BUILD_JSON_WRITER
expectations.reset(SkNEW_ARGS(DM::JsonExpectations, (path)));
+#endif
}
}
}
« no previous file with comments | « no previous file | dm/DMExpectations.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698