Command line switch to disable GView PDF handling.

ChromeOS PDF handling: if the built-in PDF viewer plug-in is active, don't intercept PDF opening and forward to gView, but use the plug-in instead.

BUG=chromium-os:4790
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52770

[sanjeevr, 2010-07-15 02:45:59]

I wonder whether we should check if the internal PDF plugin is available and
enabled and enable GView redirection based on that rather than a command-line
switch.

But then we would need to enable/disable this redirection dynamically when the
plugin is disabled/enabled.

[Scott Byer, 2010-07-15 16:57:04]

On 2010/07/15 02:45:59, sanjeevr wrote:
> I wonder whether we should check if the internal PDF plugin is available and
> enabled and enable GView redirection based on that rather than a command-line
> switch.
> 
> But then we would need to enable/disable this redirection dynamically when the
> plugin is disabled/enabled.

If you give me a hint as to how to tell if the plug-in is enabled/disabled, and
if there's a notification on plug-in enablement/disablement, the dynamic part is
pretty easy.  But disabling the plug-in isn't something (currently?) exposed on
ChromiumOS, which is the only place I expect the command line switch to be used.

I'm thinking of keeping things simple for now, we can go dynamic if the option
to disable the plug-in on ChromiumOS is ever exposed.

-Scott

[Scott Byer, 2010-07-16 00:11:17]

On 2010/07/15 02:45:59, sanjeevr wrote:
> I wonder whether we should check if the internal PDF plugin is available and
> enabled and enable GView redirection based on that rather than a command-line
> switch.
> 
> But then we would need to enable/disable this redirection dynamically when the
> plugin is disabled/enabled.

Ok, try this version of the patch on for size.  I played with enabling/disabling
the plug-in and it's doing the right thing when launched with --enable-gview
--disable-gview-pdf.

[Scott Byer, 2010-07-16 18:19:21]

On 2010/07/16 00:11:17, Scott Byer wrote:
> On 2010/07/15 02:45:59, sanjeevr wrote:
> > I wonder whether we should check if the internal PDF plugin is available and
> > enabled and enable GView redirection based on that rather than a
command-line
> > switch.
> > 
> > But then we would need to enable/disable this redirection dynamically when
the
> > plugin is disabled/enabled.
> 
> Ok, try this version of the patch on for size.  I played with
enabling/disabling
> the plug-in and it's doing the right thing when launched with --enable-gview
> --disable-gview-pdf.

Simplified; took out the flag.  Dropped most of the files out of the patch.

[sanjeevr, 2010-07-16 21:48:55]

LGTM

[Avi, 2010-07-16 23:26:34]

On 2010/07/16 21:48:55, sanjeevr wrote:
> LGTM

The description of this CL is wrong now. Please update it before landing.