Issue 2906009: Remove fields that are unused and reference classes that do not exist.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2906009: Remove fields that are unused and reference classes that do not exist. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Robert Sesek

Modified:
4 years ago

Reviewers:
Avi

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Remove fields that are unused and reference classes that do not exist. BUG=none TEST=compile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52314

Patch Set 3 : Update comment #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
M	chrome/browser/cocoa/browser_window_controller.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/throbber_view.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/throbber_view.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Trybot results:

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi

http://codereview.chromium.org/2906009/diff/2001/3002 File chrome/browser/cocoa/throbber_view.h (left): http://codereview.chromium.org/2906009/diff/2001/3002#oldcode12 chrome/browser/cocoa/throbber_view.h:12: @class ThrobberTimerTarget; This is referred to by a comment ...

4 years, 10 months ago (2010-07-13 22:51:51 UTC) #2

Robert Sesek

4 years, 10 months ago (2010-07-13 22:54:51 UTC) #3

LG.

Nice editing of the comment.

Expand Messages | Collapse Messages

Issue 2906009: Remove fields that are unused and reference classes that do not exist. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Update comment #

Messages