components/prefs/persistent_pref_store.h - Issue 2905903002: Delete the PreferenceMACs on profile deletion.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/prefs/persistent_pref_store.h

Issue 2905903002: Delete the PreferenceMACs on profile deletion. (Closed)

Patch Set: Try loading unloaded profiles before calling OnStoreDeletionFromDisk Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/prefs/overlay_user_pref_store.cc ('k') | components/prefs/pref_filter.h » ('j') | components/prefs/pref_filter.h » ('J')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_PREFS_PERSISTENT_PREF_STORE_H_	5 #ifndef COMPONENTS_PREFS_PERSISTENT_PREF_STORE_H_

6 #define COMPONENTS_PREFS_PERSISTENT_PREF_STORE_H_	6 #define COMPONENTS_PREFS_PERSISTENT_PREF_STORE_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "components/prefs/base_prefs_export.h"	10 #include "components/prefs/base_prefs_export.h"

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66	66

67 // Schedule a write if there is any lossy data pending. Unlike	67 // Schedule a write if there is any lossy data pending. Unlike

68 // CommitPendingWrite() this does not immediately sync to disk, instead it	68 // CommitPendingWrite() this does not immediately sync to disk, instead it

69 // triggers an eventual write if there is lossy data pending and if there	69 // triggers an eventual write if there is lossy data pending and if there

70 // isn't one scheduled already.	70 // isn't one scheduled already.

71 virtual void SchedulePendingLossyWrites() = 0;	71 virtual void SchedulePendingLossyWrites() = 0;

72	72

73 // It should be called only for Incognito pref store.	73 // It should be called only for Incognito pref store.

74 virtual void ClearMutableValues() = 0;	74 virtual void ClearMutableValues() = 0;

75	75

	76 // Cleans data stored outside of the profile directory.
	gab 2017/06/08 16:14:28 Don't mention "profile". re-use formulation simil Don't mention "profile". re-use formulation similar to PrefService. proberge 2017/06/08 18:32:59 Done. Show quoted text On 2017/06/08 16:14:28, gab wrote: > Don't mention "profile". > > re-use formulation similar to PrefService. Done.
	77 virtual void OnStoreDeletionFromDisk() = 0;

	78

76 protected:	79 protected:

77 ~PersistentPrefStore() override {}	80 ~PersistentPrefStore() override {}

78 };	81 };

79	82

80 #endif // COMPONENTS_PREFS_PERSISTENT_PREF_STORE_H_	83 #endif // COMPONENTS_PREFS_PERSISTENT_PREF_STORE_H_

OLD	NEW