Delete the PreferenceMACs on profile deletion.

components/prefs/pref_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This provides a way to access the application's current preferences.
 
 // Chromium settings and storage represent user-selected preferences and
 // information and MUST not be extracted, overwritten or modified except
 // through Chromium defined APIs.
 
@@ skipping 289 matching lines @@
   //
   // As an example, prefs registration in Chrome is triggered by the
   // functions chrome::RegisterPrefs (for global preferences) and
   // chrome::RegisterProfilePrefs (for user-specific preferences)
   // implemented in chrome/browser/prefs/browser_prefs.cc.
   PrefRegistry* DeprecatedGetPrefRegistry();
 
   // Clears mutable values.
   void ClearMutableValues();
 
+  // Called during profile deletion to allow for deletion of pref-related data
+  // stored outside of the profile directory.
+  void CleanupForProfileDeletion();

[gab, 2017/06/05 17:28:57]

// Invoked when the store is deleted from disk. Allows this PrefService 
// to tangentially cleanup data it may have saved outside the store.
void OnStoreDeletionFromDisk();

(everywhere)


1) components/prefs isn't aware of "profiles"
2) although we can hint at that in the comment, the method name itself shouldn't
enforce that this signal be used strictly for cleanup

[proberge, 2017/06/05 21:22:11]

Done.

+
  protected:
   // The PrefNotifier handles registering and notifying preference observers.
   // It is created and owned by this PrefService. Subclasses may access it for
   // unit testing.
   std::unique_ptr<PrefNotifierImpl> pref_notifier_;
 
   // The PrefValueStore provides prioritized preference values. It is owned by
   // this PrefService. Subclasses may access it for unit testing.
   std::unique_ptr<PrefValueStore> pref_value_store_;
 
@@ skipping 74 matching lines @@
 
   // Local cache of registered Preference objects. The pref_registry_
   // is authoritative with respect to what the types and default values
   // of registered preferences are.
   mutable PreferenceMap prefs_map_;
 
   DISALLOW_COPY_AND_ASSIGN(PrefService);
 };
 
 #endif  // COMPONENTS_PREFS_PREF_SERVICE_H_