Delete the PreferenceMACs on profile deletion.

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <stdint.h>
 
 #include <map>
 #include <set>
@@ skipping 1473 matching lines @@
       if (sync_service->IsSyncRequested()) {
         // Record sync stopped by profile destruction if it was on before.
         UMA_HISTOGRAM_ENUMERATION("Sync.StopSource",
                                   syncer::PROFILE_DESTRUCTION,
                                   syncer::STOP_SOURCE_LIMIT);
       }
       // Ensure data is cleared even if sync was already off.
       ProfileSyncServiceFactory::GetInstance()
           ->GetForProfile(profile)
           ->RequestStop(browser_sync::ProfileSyncService::CLEAR_DATA);
+
+      // Clean-up pref data that won't be cleaned up by NukeProfileFromDisk.
+      profile->GetPrefs()->CleanupForProfileDeletion();

[gab, 2017/06/05 17:28:57]

Why is this inside if
(ProfileSyncServiceFactory::GetInstance()->HasProfileSyncService() { ... } ?

[proberge, 2017/06/05 21:22:11]

My bad, I thought I put it under if (profile) {}. 

     }
 
     ProfileAttributesEntry* entry;
     bool has_entry = storage.GetProfileAttributesWithPath(profile_dir, &entry);
     DCHECK(has_entry);
     ProfileMetrics::LogProfileDelete(entry->IsAuthenticated());
     // Some platforms store passwords in keychains. They should be removed.
     scoped_refptr<password_manager::PasswordStore> password_store =
         PasswordStoreFactory::GetForProfile(
             profile, ServiceAccessType::EXPLICIT_ACCESS).get();
@@ skipping 276 matching lines @@
 
   const base::FilePath new_active_profile_dir =
       found_entry ? found_entry->GetPath() : GenerateNextProfileDirectoryPath();
   FinishDeletingProfile(profile_dir, new_active_profile_dir);
 }
 #endif  // !defined(OS_ANDROID)
 
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }