chrome/browser/ui/BUILD.gn - Issue 2905833004: [OverlayWindow] Add platform-independent window and views implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2905833004: [OverlayWindow] Add platform-independent window and views implementation. (Closed)

Patch Set: Remove BaseWindow subclassing per conversation with sky@. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/BUILD.gn

diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn

index 9afc47326a2b9d95409bdd68afb786b19938274c..cc270ed6bbf48f8febffa5735fe5d9ffb65b9301 100644

--- a/chrome/browser/ui/BUILD.gn

+++ b/chrome/browser/ui/BUILD.gn

@@ -787,6 +787,7 @@ split_static_library("ui") {

"omnibox/chrome_omnibox_navigation_observer.h",

"omnibox/clipboard_utils.cc",

"omnibox/clipboard_utils.h",

+ "overlay/overlay_window.h",

"page_info/page_info_infobar_delegate.cc",

"page_info/page_info_infobar_delegate.h",

"page_info/permission_menu_model.cc",

@@ -1545,6 +1546,8 @@ split_static_library("ui") {

"views/login_view.h",

"views/new_back_shortcut_bubble.cc",

"views/new_back_shortcut_bubble.h",

+ "views/overlay/overlay_window_views.cc",

+ "views/overlay/overlay_window_views.h",

"views/page_info/chosen_object_row.cc",

"views/page_info/chosen_object_row.h",

"views/page_info/chosen_object_row_observer.h",