Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: chrome/browser/ui/views/overlay/overlay_window_views.h

Issue 2905833004: [OverlayWindow] Add platform-independent window and views implementation. (Closed)
Patch Set: Changes per sky@ and mlamouri@'s comments. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_UI_VIEWS_OVERLAY_OVERLAY_WINDOW_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_OVERLAY_OVERLAY_WINDOW_VIEWS_H_
7
8 #include "chrome/browser/ui/overlay/overlay_window.h"
9 #include "ui/views/widget/widget.h"
sky 2017/07/18 16:48:07 Forward declare Widget.
apacible 2017/07/19 00:44:12 Done.
10
11 // The Views implementation of OverlayWindow.
12 class OverlayWindowViews : public OverlayWindow {
13 public:
14 OverlayWindowViews();
15 ~OverlayWindowViews() override;
16
17 void Init() override;
sky 2017/07/18 16:48:07 Generally we prefix overrides with a comment as to
apacible 2017/07/19 00:44:12 Done.
18 bool IsActive() const override;
19 void Show() override;
20 void Hide() override;
21 void Close() override;
22 void Activate() override;
23 bool IsAlwaysOnTop() const override;
24 ui::Layer* GetLayer() override;
25 gfx::NativeWindow GetNativeWindow() const override;
26 gfx::Rect GetBounds() const override;
27
28 private:
29 std::unique_ptr<views::Widget> widget_;
sky 2017/07/18 16:48:07 If you're going to own the widget then you should
apacible 2017/07/19 00:44:12 Done.
30
31 DISALLOW_COPY_AND_ASSIGN(OverlayWindowViews);
32 };
33
34 #endif // CHROME_BROWSER_UI_VIEWS_OVERLAY_OVERLAY_WINDOW_VIEWS_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/overlay/overlay_window.h ('k') | chrome/browser/ui/views/overlay/overlay_window_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698